New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #58 #66
Closes #58 #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few notes to improve the end user experience.
Thanks for your awesome work!
@aguilaair thanks for the review, I will implement the needful changes. |
Ok, thanks again for putting your time into this feature! I appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll do some minor changes and see of I can implement support for Windows and MacOS than i think it is ready to merge!
Thanks for you help 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation currently does not work with Web. dart:io
is used and is therefore is incompatible with web. Additionally, the file picker will always return a Uint8List
in web as paths aren't supported. If you have a chance to fix it it would be great!
I will fix it as soon as I can thanks for the review @aguilaair |
Thank you for your effort! I really appreciate it. |
…and mobile platform
@aguilaair I have tested attachment upload and download on android device and on web (chrome), I am not able to test it on iOS device if it is possible for you to test it on iOS please do although I don't think it will not work on iOS. If you want anything changed please let me know. Thank you! |
Great! I'll check it out ASAP |
Looks great! Made a few tewaks to show the body even if an attachment is shown and also tweaked some alerts to be more neutral themed. Thanks for your effort. I believe this can now be merged and it will be included in the next release! |
No description provided.