Fix namespaces of exported svg #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for spotting! For future reference, it would be good to create an issue for the problem, and then reference it from the commits that fix it, so the changes are explained. The current commit messages are not very clear, as they don't mention IE at all. But tis' fine, I'll add code comments after merging. |
|
The added slashes break SVG importing in some cases (see for example the failed Travis CI build: https://travis-ci.org/paperjs/paper.js/builds/110370095, or open |
lehni
added a commit
that referenced
this pull request
Feb 19, 2016
|
I found a fix for it. IE appears to be very inconsistent. The slash seems to be only required when calling |
lehni
added a commit
that referenced
this pull request
Feb 19, 2016
|
This fix breaks the |
lehni
added a commit
that referenced
this pull request
Mar 14, 2016
bmacnaughton
added a commit
to bmacnaughton/paper.js
that referenced
this pull request
Mar 22, 2016
Commits not documented listed here, starting with 45595b2. They are not included in the changelog because the appeared to be internal or already documented or they were a fix for a bug that was introduced in "develop" branch. There were commits before 45595b2 but that's when I started recording what I didn't put in the changelog. Not sure whether the curveAt/CurveAtTime functions are deprecated or removed. Format: commit message, commit ID. In chronological order of commits: - Fix unit test error on Node.js 45595b2 - Implement unit tests for SVG Importing, based on visual comparison. … a12e99e - Fix wrongly copied attributes in Item#reduce() … 8e25327 - Events: paper namespace may not be initialized when key evens are emi… … b2f3b58 - SVG: Some renaming omitted in previous commit. 1c4ff31 - SVG: Rename 'SVG' prefix to 'Svg' … af59847 - Implement tests for paperjs#697 … 21dce1a - Move Path_Bounds tests to Item_Bounds. … a02d724 - Fix accidentally leaked global variable. 74d1889 - Simplify getWindings(), The first curve of a loop always has the 'las… … 0716ebb - Merge pull request paperjs#938 from iconexperience/getWinding-simplification … 53269ab - Optimize Emitter._installEvents() … 0f084ea - JSON: Prevent `name: undefined` exports. 7888d1d - Change the way we determine the winding in getWinding(). Now the wind… … aed9d05 (paperjs#936) - Clean-up changes from paperjs#939 41aca10 - Define unit test for #internalBounds regression. 336460b - Fix internalBounds regression caused by 1ac8e46 0152439 - Revert "Change the way we determine the winding in getWinding()." f7b1aca - Use correct SVG namespace again. … fc4bdf4 - Replace the "straight curves with zero-winding" test with a more comp… … e03c8cd - Change the implementation of getWinding() again, so we pass all tests… … 5b31aee - Merge pull request paperjs#944 from iconexperience/fix-getWinding … ec75985 - Merge pull request paperjs#943 from iconexperience/replace-path-contains-test … 23045bb - Do not snap curve points to t = 0 / 1 with epsilon … 0371f66 (in boolean ops) - Clean-up unit test for paperjs#943 and add edge case from paperjs#944 … a59a535 - Some comment cleanup. ffe42a0 - Merge branch 'winding-fix' into develop … 5a46620 - Some code cleanup for winding-fix. 55909b8 - Include NPM and Bower badges. 80e6246 - Improve handling of view updates and detection of invisible documents. … da216aa - Fix new exception in unit tests. de9653a - Rearrange method sequence in Path. d1b11c6 - Clean-up PathFitter code. e5d139c - No need to pass normalized tangents to PathFitter#fitCubic() … c793538 - Fix JSDoc warning on Style class. a48d138 - Implement PathItem#getNearestLocation() / #getNearestPoint() … 717bc4b - Implement Item#_hitTestChildren() … 740c94e - Some CurveLocation cleanup. … 00d2e2a - Remove duplicate unit tests. ed43477 - SVGExport: Remove unnecessary calls to Point#transform() in exportGra… … adc5b86 - Remove unnecessary double-spaces. 98fc513 - Improve fix for paperjs#650 … c1b7366 - SVGImport: Further improve handling of gradients … d9e09b9 - Gulp: Add test:browser task, to solve CORS issues on Chrome. 8542eb6 - SVGImport: Improve consistency of style handling. df57c4a - SVGImport: Inherit default styles on Node.js too. e38a33f - SvgImport: Always create a clip-item when viewBox is specified. 68c4541 - Tests: Implement additional tests for SvgImport. c0b39c4 - Travis CI: Use Arial in all tests. cb79232 - Shortcut Curve.evaluate() for t === 1 to avoid imprecision. aa1f219 (paperjs#960) - Part 1 of large refactoring of bounds handling. 55c5f42 - Update straps.js 892e567 - Part 2 of large refactoring of bounds handling. 12f829c - Travis CI: Switch to g++ 4.8 to see if this solves strange new buildi… … 5ec5c26 - Introduce Base.filter(), to copy and filter object properties. 6d5d1ce - Implement unit tests for Item#getItems() with overlapping / inside pr… … 80c8aae - Merge pull request paperjs#962 from iconexperience/fix-issue-960 … 7c24fc9 - Add test for paperjs#960 and improve fix a bit. … e2bc83a - Remove unnecessary edge-case handling in CurveLocation#isCrossing() … 84a75e3 (paperjs#951, paperjs#959 - but falls into boolean fixes in general). - Implement consistent checks for fill / stroke / shadow styles in test… … c6bcf43 - Clean-up previous commit. 0a196da - Boolean: Implement proper handling of fully overlapping (identical) p… … 3348fb7 (paperjs#923, paperjs#958 - but falls into boolean fixes in general). - Boolean: Only compare segments when determining if paths are identitcal. 009761d (boolean fixes in general). - Switch from new Base() to Base.set({}) where possible. c3fff9f - Docs: Fix warning about isFlatEnough() 27197bd - Better detect code that requires a tool object. … dbd7a90 (in example fixes) - Matrix: Switch to a better implementation of #decompose() … 3ee46ff - Implement failing test for paperjs#968 9c9f43d - Hit-Test: Pass viewMatrix as argument instead of in options object. fa6c1f4 - Update Curve.js … fb76065 - Update Path.js … add2866 - Clean up PR paperjs#931 … 79d4461 - Improve handling of points on paths in getWinding() e2eaf87 - Adjust comments to match new implementation 406e6c9 - Fix regression introduced in 4e7fa2f 55e7689 - Implement more unit tests for PaperScope#settings.insertItems 01fade8 - Merge pull request paperjs#971 from iconexperience/fix-issue-968 … 4c72d98 (boolean fixes in general) - Simplify code from paperjs#971 and activate unit test for it again. 8d5c922 - Document options.insert in #importSVG() 3c3c8d9 - List all supported events in event methods on View. 9f9222f - Switch to PathItem.create() in unit tests. 0e2498b - Fix failing SVG unit test. 08e51b5 - Fix failing unit tests. 3d330da - SvgImport: Fix issues introduced in 6f4890c 16a7baa - Merge pull request paperjs#976 from iconexperience/patch-2 … 7f48486 - SVG Export: Do not filter out empty paths. 6975690 - Fix paperjs#977: Apply hit-testing tolerance to fills in Shape. 4081afb - Fix paperjs#977: Implement unit-tests. 6df4602 - Fix paperjs#982: Make sure `self` points to the global scope on Webpack. b5c837b - Extend mapping of attribute names to required namespaces a4757b3 - Add trailing slashes to svg related namespaces (xmlns, xlink) 49104c5 - Merge pull request paperjs#984 from aschmi/fix-namespaces-of-exported-svg … 623ec73 - SVG Import: Fix namespacing issues introduced by paperjs#984. acb1e40 - SVG: Add comments explaining IE related changes in paperjs#984. 50bd5be - Implement unit tests for paperjs#991 … 1cb2916 - fix paperjs#994: Revert commit b5af47a … 69c3470 - Rename SegmentSelection related internal objects and properties. … 1db419a - Simplify Path#getArea() … 7dd110f - jsdom v8.0.0 equires Node.js v4.0.0 or newer. 7300260 - Implement Path#splitAt(offset) … da7d0d8 - Add more unit tests for SvgImport. … 7a4794d - SVG Import: Add more tests. … d52a6f3 - Refactor GradientStop: Improve handling of optionally defined color a… … d93aca6 - Travis CI: See if using Arial solves the failing test. 17555b1 - Travis CI: Use Arial in all SVG tests and reduce tolerance. d6ce470 - Travis CI: Adjust SVG test tolerances. beabd6b - Travis CI: More SVG test adjustments. bb19fad - Replace Item#_boundsSelected with #_selectBounds … 336bc10 - More clean-up of selection handling refactoring. 00b2102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this fix addresses an issue I've had with the
exportSVGfunction in Internet Explorer 11 (on Windows 7). The resulting SVG appeared to be corrupted. The problem was that the svg-tag had invalid namespace attributes:The following result of exportSVG
<svgxmlns="http://www.w3.org/2000/svg"x="0" y="0" width="870" height="870" version="1.1"xmlns:NS1="" NS1:xmlns:xlink="http://www.w3.org/1999/xlink“>…</svg>should have been
<svg x="0" y="0" width="870" height="870" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink“>…</svg>I found a description of the exact same problem as well as a solution in this SO