Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Include error information when Redis connection fails #1016

Merged
merged 1 commit into from
May 24, 2022
Merged

Feature: Include error information when Redis connection fails #1016

merged 1 commit into from
May 24, 2022

Conversation

stumpylog
Copy link
Member

Proposed change

When the wait for Redis at image startup fails, include the exception string in the log for easier debugging.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner May 23, 2022 23:56
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label May 23, 2022
shamoon
shamoon approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@shamoon shamoon merged commit f7539eb into dev May 24, 2022
@shamoon shamoon deleted the more-redis-wait-info branch May 24, 2022 02:12
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
deployment enhancement New feature non-trivial Requires approval by several team members
Projects
Paperless-ngx
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stumpylog @shamoon