Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .env #102

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Update .env #102

merged 1 commit into from
Feb 24, 2022

Conversation

Timoms
Copy link
Contributor

@Timoms Timoms commented Feb 19, 2022

Added visual indicator that pipenv is active as mentioned in #97

added visual indicator that pipenv is active
@Timoms Timoms linked an issue Feb 19, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Feb 19, 2022

Pull Request Test Coverage Report for Build 1867217758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.084%

Totals Coverage Status
Change from base Build 1865042100: 0.0%
Covered Lines: 3920
Relevant Lines: 4257

💛 - Coveralls

@yschroeder
Copy link
Contributor

This does not work for me. If I do pipenv shell my prompt looks like before. I am using zsh with GRML config which already heavily mods my prompt.

It works in a plain bash though.

So I guess LGTM.

@Timoms
Copy link
Contributor Author

Timoms commented Feb 20, 2022

So it doesn't mess up your current config but improves the "normal" bash one, right?
Don't want this PR to mess with other configs but improve default ones.

I am a WSL2/Ubuntu user with some minimal mods to the bashrc - and it makes quite the difference.

@tribut
Copy link
Member

tribut commented Feb 20, 2022

This looks harmless enough, but is feels like this belongs to pipenv, not every project using it.

Indeed, pipenv includes code that should be doing exactly the same thing: https://github.com/pypa/pipenv/blob/main/pipenv/shells.py#L91-L94

Just found this upstream issue - apparently it's a pipenv/powershell bug? pypa/pipenv#3505

@Timoms
Copy link
Contributor Author

Timoms commented Feb 20, 2022

This looks harmless enough, but is feels like this belongs to pipenv, not every project using it.

Indeed, pipenv includes code that should be doing exactly the same thing: https://github.com/pypa/pipenv/blob/main/pipenv/shells.py#L91-L94

Just found this upstream issue - apparently it's a pipenv/powershell bug? pypa/pipenv#3505

Seems like the issue is around since 2018 and got only fixed for cmd recently.
I am not sure if pipenv fixes this in the near future (since the mentioned issue is around like 2 years now).

@tribut
Copy link
Member

tribut commented Feb 20, 2022

If your change doesn't duplicate the prompt for systems where it currently works (if any), sure. We can remove it later once it works.

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other] Add prompt to env file for better visibility of pipenv
5 participants