-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .env #102
Update .env #102
Conversation
added visual indicator that pipenv is active
Pull Request Test Coverage Report for Build 1867217758
💛 - Coveralls |
This does not work for me. If I do It works in a plain bash though. So I guess LGTM. |
So it doesn't mess up your current config but improves the "normal" bash one, right? I am a WSL2/Ubuntu user with some minimal mods to the bashrc - and it makes quite the difference. |
This looks harmless enough, but is feels like this belongs to pipenv, not every project using it. Indeed, pipenv includes code that should be doing exactly the same thing: https://github.com/pypa/pipenv/blob/main/pipenv/shells.py#L91-L94 Just found this upstream issue - apparently it's a pipenv/powershell bug? pypa/pipenv#3505 |
Seems like the issue is around since 2018 and got only fixed for cmd recently. |
If your change doesn't duplicate the prompt for systems where it currently works (if any), sure. We can remove it later once it works. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Added visual indicator that pipenv is active as mentioned in #97