Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Manually downgrade reportlab (and update everything else) #1116

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

stumpylog
Copy link
Member

Proposed change

No idea why it broke as nothing in their changelog indicates a new requirement, unless it was only working due to a fixed bug.

But anyway, this quickly fixes the Docker image build for dev.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog added the bug Bug report or a Bug-fix label Jun 8, 2022
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im guessing youre waiting for ci to double-check this?

@stumpylog
Copy link
Member Author

Yeah, 95% sure it build reportlab already, but I'll let it finish

@stumpylog
Copy link
Member Author

Ah, I see why it broke: https://www.piwheels.org/project/reportlab/

@stumpylog stumpylog marked this pull request as draft June 8, 2022 17:34
@stumpylog stumpylog marked this pull request as ready for review June 8, 2022 19:14
@stumpylog stumpylog requested a review from a team as a code owner June 8, 2022 19:14
@stumpylog
Copy link
Member Author

Ok, I've manually downgraded reportlab in requirements.txt, while also grabbing all the upgrades we have pending for other things. Once everything completes building (hopefully in around an hour at most), dev will be working again.

@stumpylog stumpylog changed the title Chore: Add new build dependency for reportlab Chore: Manually downgrade reportlab (and update everything else) Jun 8, 2022
@shamoon
Copy link
Member

shamoon commented Jun 8, 2022

Linking piwheels/packages#305

Thanks as always stumpy, will let the docker image build here go then hopefully all good!

@stumpylog
Copy link
Member Author

A bit over an hour, but looks alright build-wise now. Hopefully piwheels get that version rebuilt soon.

@stumpylog stumpylog merged commit 15c716e into dev Jun 8, 2022
@stumpylog stumpylog deleted the feature-bugfix-reportlab branch June 8, 2022 20:32
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants