Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Add v1.8.0 changelog #1298

Merged
merged 2 commits into from Jul 29, 2022
Merged

[Documentation] Add v1.8.0 changelog #1298

merged 2 commits into from Jul 29, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This PR is auto-generated by CI.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 28, 2022
@paperless-ngx-secretary
Copy link

Hello @github-actions[bot],

thank you very much for submitting this PR to us!

This is what will happen next:

  1. My robotic colleagues will check your changes to see if they break anything. You can see the progress below.
  2. Once that is finished, human contributors from paperless-ngx review your changes. Since this seems to be a small change, only a single contributor has to review your changes.
  3. Please improve anything that comes up during the review until your pull request gets approved.
  4. Your pull request will be merged into the dev branch. Changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby.
If any action will be required by you, please reply within a month.

@shamoon
Copy link
Member

shamoon commented Jul 28, 2022

This is incorrect, only has changes between rc and release, we can troubleshoot but will fix this now. (Same thing happened on release notes obv)

@shamoon shamoon merged commit e73db49 into main Jul 29, 2022
@shamoon shamoon deleted the v1.8.0-changelog branch July 29, 2022 02:52
@qcasey
Copy link
Member

qcasey commented Jul 29, 2022

Thank you for fixing that manually, I'll check why the changelog didn't include the entire PR.

@tooomm
Copy link
Contributor

tooomm commented Jul 29, 2022

This is incorrect, only has changes between rc and release. (...) (Same thing happened on release notes obv)

I'll check why the changelog didn't include the entire PR.

@qcasey The changelog (and release notes) are still missing some PR's. (e.g. #1032)
It looks like contributors are also not recognized and listed in a special Contributors category at the end by GitHub for some reason. That used to work in v1.7.1. The name highlighting is different as well, maybe because of the manual md linking []() that interferes with GitHub automatically highlighting @ usernames?

FYI: The demo is still running v1.7.1.

@qcasey
Copy link
Member

qcasey commented Jul 29, 2022

Thanks for pointing those out.

  • The majority of the PRs went missing because release notes were drafted for the pre-release. This line might have to be conditional.
  • I think you're right about the manual name linking causing the missing contributors section. One thing we could do is replace the @ mentions with manual md links for the appended changelog only, and let github link usernames in the release notes. Or something else, not sure yet
  • I have no idea what happened to Feature mail action custom tag #1032

@qcasey
Copy link
Member

qcasey commented Jul 29, 2022

Oh wait, I think the missing PRs are when their only label is documentation, which isn't included. I'll fix that as well

@qcasey qcasey mentioned this pull request Jul 29, 2022
13 tasks
@tooomm
Copy link
Contributor

tooomm commented Jul 30, 2022

I think you're right about the manual name linking causing the missing contributors section.

Yep, looks like adjusting the @ links in the 1.8.0 release did the trick. 👍

@github-actions
Copy link
Contributor Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants