Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dont require admin perms to view trash on frontend #7028

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix: dont require admin perms to view trash on frontend #7028

merged 1 commit into from
Jun 19, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jun 19, 2024 •
edited
Loading

Proposed change

Closes #7021

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner June 19, 2024 03:13
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jun 19, 2024
@shamoon shamoon added this to the v2.10.1 milestone Jun 19, 2024
@shamoon shamoon mentioned this pull request Jun 19, 2024
Closed
3 tasks
@shamoon shamoon merged commit cd0af70 into dev Jun 19, 2024
23 checks passed
@shamoon shamoon deleted the fix-7021 branch June 19, 2024 03:14
shamoon added a commit that referenced this pull request Jun 19, 2024
@shamoon
Fix: dont require admin to view trash on frontend (#7028)
a066ccf
calvinbui pushed a commit to calvinbui/ansible-monorepo that referenced this pull request Jun 20, 2024
@renovate-bot
ghcr.io/paperless-ngx/paperless-ngx: update version to v2.10.1 (#2656)
de64ad2 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/paperless-ngx/paperless-ngx](https://github.com/paperless-ngx/paperless-ngx) | minor | `2.9.0` -> `2.10.1` |

---

### Release Notes

<details>
<summary>paperless-ngx/paperless-ngx (ghcr.io/paperless-ngx/paperless-ngx)</summary>

### [`v2.10.1`](https://github.com/paperless-ngx/paperless-ngx/releases/tag/v2.10.1): Paperless-ngx v2.10.1

[Compare Source](paperless-ngx/paperless-ngx@v2.10.0...v2.10.1)

#### paperless-ngx 2.10.1

> \[!NOTE]\
> This is planned to be the last release series to support Gotenberg 7, see [the discussion](paperless-ngx/paperless-ngx#7025) for more information.

##### ⚠️ Heads Up!

Paperless-ngx v2.10.x fixes an issue with `ui_settings` permissions, which are required for users to use the web frontend.

##### Bug Fixes

-   Fix: dont require admin perms to view trash on frontend [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7028](paperless-ngx/paperless-ngx#7028))

### [`v2.10.0`](https://github.com/paperless-ngx/paperless-ngx/releases/tag/v2.10.0): Paperless-ngx v2.10.0

[Compare Source](paperless-ngx/paperless-ngx@v2.9.0...v2.10.0)

#### paperless-ngx 2.10.0

> \[!NOTE]\
> This is planned to be the last release series to support Gotenberg 7, see [the discussion](paperless-ngx/paperless-ngx#7025) for more information.

##### Features

-   Feature: documents trash aka soft delete [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6944](paperless-ngx/paperless-ngx#6944))
-   Enhancement: better boolean custom field display [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7001](paperless-ngx/paperless-ngx#7001))
-   Feature: Allow encrypting sensitive fields in export [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6927](paperless-ngx/paperless-ngx#6927))
-   Enhancement: allow consumption of odg files [@&#8203;daniel-boehme](https://github.com/daniel-boehme) ([#&#8203;6940](paperless-ngx/paperless-ngx#6940))

##### Bug Fixes

-   Fix: Document history could include extra fields [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6989](paperless-ngx/paperless-ngx#6989))
-   Fix: use local pdf worker js [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6990](paperless-ngx/paperless-ngx#6990))
-   Fix: Revert masking the content field from auditlog [@&#8203;tribut](https://github.com/tribut) ([#&#8203;6981](paperless-ngx/paperless-ngx#6981))
-   Fix: respect model permissions for tasks API endpoint [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6958](paperless-ngx/paperless-ngx#6958))
-   Fix: Make the logging of an email message to be something useful [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6901](paperless-ngx/paperless-ngx#6901))

##### Documentation

-   Documentation: Corrections and clarifications for Python support [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6995](paperless-ngx/paperless-ngx#6995))

##### Maintenance

-   Chore(deps): Bump stumpylog/image-cleaner-action from 0.6.0 to 0.7.0 in the actions group [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;6968](paperless-ngx/paperless-ngx#6968))
-   Chore: Configures dependabot to ignore djangorestframework [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6967](paperless-ngx/paperless-ngx#6967))

##### Dependencies

<details>
<summary>10 changes</summary>

-   Chore(deps): Bump pipenv from 2023.12.1 to 2024.0.1 [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7019](paperless-ngx/paperless-ngx#7019))
-   Chore(deps): Bump the small-changes group with 2 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7013](paperless-ngx/paperless-ngx#7013))
-   Chore(deps-dev): Bump the development group with 2 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7012](paperless-ngx/paperless-ngx#7012))
-   Chore(deps-dev): Bump ws from 8.15.1 to 8.17.1 in /src-ui [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7015](paperless-ngx/paperless-ngx#7015))
-   Chore(deps): Bump urllib3 from 2.2.1 to 2.2.2 [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7014](paperless-ngx/paperless-ngx#7014))
-   Chore: update packages used by mail parser html template [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6970](paperless-ngx/paperless-ngx#6970))
-   Chore(deps): Bump stumpylog/image-cleaner-action from 0.6.0 to 0.7.0 in the actions group [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;6968](paperless-ngx/paperless-ngx#6968))
-   Chore(deps-dev): Bump the development group with 3 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;6953](paperless-ngx/paperless-ngx#6953))
-   Chore: Updates to latest Trixie version of Ghostscript 10.03.1 [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6956](paperless-ngx/paperless-ngx#6956))
-   Chore(deps): Bump tornado from 6.4 to 6.4.1 [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;6930](paperless-ngx/paperless-ngx#6930))

</details>

##### All App Changes

<details>
<summary>17 changes</summary>

-   Chore(deps): Bump the small-changes group with 2 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7013](paperless-ngx/paperless-ngx#7013))
-   Chore(deps-dev): Bump the development group with 2 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7012](paperless-ngx/paperless-ngx#7012))
-   Chore(deps-dev): Bump ws from 8.15.1 to 8.17.1 in /src-ui [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7015](paperless-ngx/paperless-ngx#7015))
-   Feature: documents trash aka soft delete [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6944](paperless-ngx/paperless-ngx#6944))
-   Enhancement: better boolean custom field display [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7001](paperless-ngx/paperless-ngx#7001))
-   Fix: default order of documents gets lost in QuerySet pipeline [@&#8203;madduck](https://github.com/madduck) ([#&#8203;6982](paperless-ngx/paperless-ngx#6982))
-   Fix: Document history could include extra fields [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6989](paperless-ngx/paperless-ngx#6989))
-   Fix: use local pdf worker js [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6990](paperless-ngx/paperless-ngx#6990))
-   Fix: Revert masking the content field from auditlog [@&#8203;tribut](https://github.com/tribut) ([#&#8203;6981](paperless-ngx/paperless-ngx#6981))
-   Chore: update packages used by mail parser html template [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6970](paperless-ngx/paperless-ngx#6970))
-   Chore(deps-dev): Bump the development group with 3 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;6953](paperless-ngx/paperless-ngx#6953))
-   Fix: respect model permissions for tasks API endpoint [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6958](paperless-ngx/paperless-ngx#6958))
-   Feature: Allow encrypting sensitive fields in export [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6927](paperless-ngx/paperless-ngx#6927))
-   Enhancement: allow consumption of odg files [@&#8203;daniel-boehme](https://github.com/daniel-boehme) ([#&#8203;6940](paperless-ngx/paperless-ngx#6940))
-   Enhancement: use note model permissions for notes [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;6913](paperless-ngx/paperless-ngx#6913))
-   Chore: Resolves test issues with Python 3.12 [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6902](paperless-ngx/paperless-ngx#6902))
-   Fix: Make the logging of an email message to be something useful [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;6901](paperless-ngx/paperless-ngx#6901))

</details>

</details>

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Calvin Bui <calvinbui@noreply.gitea.bui.services>
Reviewed-on: https://gitea.bui.services/calvinbui/ansible-monorepo/pulls/2656
Co-authored-by: renovate <renovate@noreply.gitea.bui.services>
Co-committed-by: renovate <renovate@noreply.gitea.bui.services>
@janbaer
Copy link

janbaer commented Jun 23, 2024

After login, I still get a 403 error, even I have running Paperless-ngx 2.10.1. Only when I try to login with the admin account, it works fine. What could be wrong here?

@c10l
Copy link

c10l commented Jun 27, 2024

Similar issue as @janbaer . Downgrading to 2.9.0 makes it work again.

[WARNING] [django.request] Forbidden: /api/ui_settings/

@shamoon
Copy link
Member Author

shamoon commented Jun 27, 2024

Please don’t comment on a merged PR. If you have a question you can open a discussion. You both are not talking about the same thing.

@paperless-ngx paperless-ngx locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Paperless-ngx
Status: Done
Milestone
v2.10.1
Development

Successfully merging this pull request may close these issues.

[BUG] Permission issues with Trash (Soft Delete)
3 participants
@shamoon @janbaer @c10l