Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Safari browser PDF viewer not loading in 2.10.x #7056

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix: Safari browser PDF viewer not loading in 2.10.x #7056

merged 1 commit into from
Jun 21, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jun 21, 2024

Proposed change

This was my bad, I accidentally committed the change to the dev branch when testing out some other report and assumed it would be harmless once I realized. Of course I had forgotten how incredibly finicky Safari is, I actually remember this specific issue now from years go at -ng

Closes #7055

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner June 21, 2024 15:54
@shamoon shamoon enabled auto-merge (squash) June 21, 2024 15:55
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jun 21, 2024
@shamoon shamoon added this to the Next Release milestone Jun 21, 2024
@shamoon shamoon merged commit cccba47 into dev Jun 21, 2024
31 checks passed
@shamoon shamoon deleted the fix-7055 branch June 21, 2024 18:22
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants