-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes IMAP UTF8 Authenication #725
Conversation
If we can sneak this into the beta, it's probably good to. |
Thanks as always for another deep-dive fix! In the case of the new plain auth attempt is the error output still clear? Im just wondering if it would be helpful to include something like "non-ascii chars detected, attempting to fallback to plain auth" to make it more apparent why this all failed? |
Well, the error before was pretty generic, so I kept that, but I could see having an extra log or two would help in debugging |
864aed3
to
105a1a9
Compare
5a0c495
to
62f70f4
Compare
Pull Request Test Coverage Report for Build 2222357777
💛 - Coveralls |
0eedd7f
to
330e47f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me.
This is a pretty minor change to me, do we want the pending reviewer still or just merge? |
Agreed, let's just merge. This happens a lot, we might have to revisit that rule later on |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
In the event of a UnicodeEncodeError during normal login, we'll now try to fallback to an AUTH=PLAIN login type, which encodes the username and password differently.
I successfully tested this with a password containing UTF8 characters and was able to view the inbox.
Fixes #663
Type of change
Checklist:
pre-commit
hooks, see documentation.