Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow commas in non-multi rules query params #923

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix: allow commas in non-multi rules query params #923

merged 1 commit into from
May 11, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 11, 2022

Proposed change

This PR fixes an issue where strings with a comma , would incorrectly be interpreted as multiple values and split by the frontend causing unexpected behavior.

Screen Shot 2022-05-11 at 10 25 42 AM

Fixes #922

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added bug Bug report or a Bug-fix frontend labels May 11, 2022
@shamoon shamoon added this to the Next Release milestone May 11, 2022
@shamoon shamoon requested a review from a team as a code owner May 11, 2022 17:29
@shamoon shamoon self-assigned this May 11, 2022
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label May 11, 2022
@shamoon shamoon changed the title allow commas in non-multi rules query params Fix: allow commas in non-multi rules query params May 11, 2022
qcasey
qcasey approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@qcasey qcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, this works. Thanks!

@shamoon shamoon merged commit d230431 into dev May 11, 2022
@shamoon shamoon deleted the fix-queryparams-comma-splitting branch May 11, 2022 18:15
@shamoon shamoon mentioned this pull request Jun 2, 2022
Closed
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@qcasey qcasey qcasey approved these changes

Assignees

@shamoon shamoon

Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
Paperless-ngx
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

[BUG] Search cannot work with comma sign
2 participants
@shamoon @qcasey