Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PRs from dependabot #2

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Ignore PRs from dependabot #2

merged 1 commit into from
Feb 24, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Feb 24, 2022

@bauerj I just wanted prevent e.g. paperless-ngx/paperless-ngx#94 (comment)

TBH Im not totally sure how to test this, I mean the python is fine but just to make sure it works with webhook, vercel etc.

Was just trying to save you the time =)

@shamoon shamoon requested a review from bauerj February 24, 2022 17:22
@vercel
Copy link

vercel bot commented Feb 24, 2022

@shamoon is attempting to deploy a commit to a Personal Account on Vercel that is not owned by them.

In order for the commit to be deployed, @shamoon must be granted access to the connected Vercel project.

If you're the owner of the Personal Account, transfer the project to a Vercel Team and start collaborating, or learn more.

@bauerj
Copy link
Member

bauerj commented Feb 24, 2022

Cool, thanks!

Yes, testing this is... not ideal:

  1. First it has to be pushed on master for deployment
  2. Then I have to find a pull_request.opened event in the webhook history and resend it
  3. Check if the comment looks good, then delete it

@bauerj bauerj merged commit f4c3a11 into main Feb 24, 2022
@shamoon
Copy link
Member Author

shamoon commented Feb 24, 2022

Cool, thanks!

Yes, testing this is... not ideal:

  1. First it has to be pushed on master for deployment
  2. Then I have to find a pull_request.opened event in the webhook history and resend it
  3. Check if the comment looks good, then delete it

Whoa, yea a bit cumbersome. I'll leave that to you =)

@shamoon shamoon deleted the ignore-dependabot-prs branch February 24, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants