Update gdata gem #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good! We could probably merge/ship this whenever we want, right? |
|
@gordondiggs any thoughts on QA for this? Just make sure gmail import works? |
|
@arirusso We actually don't use this gem for google import, only AOL. Making sure the AOL import is working should be sufficient |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://www.pivotaltracker.com/n/projects/1106466/stories/84862982
Updates the gdata gem to the newer stock version (1.1.2)
Patches the require (see gmail.rb) to not include the outdated jcode gem dependency. This (please confirm) is the only change from our custom gem that is not in trunk at this point
cc @quirkey @gordondiggs