FIX: hold notifications when current window is fullscreen (Notifications are then shown when the window is un-fullscreened) #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtaala
added
the
merging soon
jtaala
added a commit
that referenced
this pull request
Jul 8, 2023
gnome behaviour now aligns with #553 (what 553 was doing on the monkey path... gnome does now).
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221.
This PR hold notifications when the currently selected window is fullscreened. Notifications are then shown when the window is un-fullscreened.
This aligns more with Gnome default behaviour (but a bit better since any missed notifications will be shown when exiting fullscreen).
Plus, fullscreen movies are nicer without notifications always showing...