Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git flags in documentation #195

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Fix git flags in documentation #195

merged 1 commit into from
Aug 6, 2019

Conversation

olantwin
Copy link
Contributor

Update documentation to use the correct git flag: -a doesn't exist. -A does (and was probably meant), but its long version --all is IMHO more understandable.

Update documentation to use the correct git flag: `-a` doesn't exist. `-A` does (and was probably meant), but its long version `--all` is IMHO more understandable.
@coveralls
Copy link

coveralls commented Jul 23, 2019

Pull Request Test Coverage Report for Build 1099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.1%) to 75.082%

Totals Coverage Status
Change from base Build 1088: -2.1%
Covered Lines: 2757
Relevant Lines: 3672

💛 - Coveralls

@teto
Copy link
Member

teto commented Aug 6, 2019

hum I think the -a is supposed to be passed to git and the manpage for git commit does mention -a. Seems like it's valid.

@olantwin
Copy link
Contributor Author

olantwin commented Aug 6, 2019

Could this depend on the git version? With git 2.21.0, the -a flag does not exist for git-add.

Edit: I think the flag is passed to git-add, when used with papis git add. When I tried the command, I got the corresponding git add error.

@teto
Copy link
Member

teto commented Aug 6, 2019

was looking at the wrong manpage (git commit instead of git add). Sry LGTM

@teto teto merged commit ddee176 into papis:master Aug 6, 2019
@olantwin olantwin deleted the patch-1 branch August 6, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants