Update more downloader tests #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
force-pushed
the
update-downloader-tests
branch
2 times, most recently
from
4a4c71c
to
88ee7ef
Compare
alexfikl
force-pushed
the
update-downloader-tests
branch
from
88ee7ef
to
0ff681c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
annualreviews: unfortunately this doesn't seem to work anymore due to some security on the website (seems to be CloudFlare's fault). There may be some headers or cookies we could set to make it work, but I haven't been able to figure anything out..aps: seems to work nicely!citeseerx: their site seems to have changed quite a bit very recently, so this also updates the downloader to the new layoutsciencedirect: updated and enabled scraping theauthor_listagain.As usual, there's probably some improvements that could be made to the downloaders, but this just gets them unittesting again! 馃殌
The diff is pretty huge, but most of it is from updating the resources, i.e. big ugly HTML files.