Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate refs in importers and downloaders #483

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Do not generate refs in importers and downloaders #483

merged 2 commits into from
Feb 8, 2023

Conversation

alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Jan 30, 2023 •
edited

This goes through the downloaders and importers and removes any automatic ref conversions, which would interfere with the automatic ref construction in commands.add.

Fixes #376.

@alexfikl alexfikl mentioned this pull request Jan 30, 2023
Closed
@alexfikl alexfikl marked this pull request as ready for review January 31, 2023 08:39
@alexfikl alexfikl changed the title Fix arXiv importer setting the ref itself Do not generate refs in importers and downloaders Feb 1, 2023
@alexfikl alexfikl merged commit 3e5750e into papis:master Feb 8, 2023
@alexfikl alexfikl deleted the fix-arxiv-ref branch February 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ref-format config does not apply to entries added via arXiv link
1 participant
@alexfikl