Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues around new configs #497

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Conversation

alexfikl
Copy link
Collaborator

This (hopefully) ensures that the config is properly set up in the following situations:

  • no config file exists => add some default sections and libraries in there.
  • no [settings] section exist => add one and make a best guess at a default-library.
  • add some warnings for these scenarios so the user isn't totally surprised.

Fixes #496.

@alejandrogallo
Copy link
Member

Thank you Alex, I apologize as this bug has been there for a while and I did not get to go about it, this is very cleanly done and also with the tests

@alexfikl
Copy link
Collaborator Author

Thank you Alex, I apologize as this bug has been there for a while and I did not get to go about it, this is very cleanly done and also with the tests

No worries at all! Thank you for taking a look 🎉

@alexfikl alexfikl merged commit fafe925 into papis:master Feb 16, 2023
@alexfikl alexfikl deleted the fix-new-config branch February 16, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config parser doesn't fall back to defaults when 'settings' section missing
2 participants