Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented downloader for papers from usenix.org #523

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

f0rki
Copy link
Contributor

@f0rki f0rki commented Mar 10, 2023

No description provided.

@alexfikl
Copy link
Collaborator

This generally looks good to me!

Can you fix the linting errors? You can see them in the CI logs
https://github.com/papis/papis/actions/runs/4383263298/jobs/7673290596

@f0rki
Copy link
Contributor Author

f0rki commented Apr 15, 2023

@alexfikl I think the CI tests are working now. I also squashed the commits and rebased.

@alexfikl
Copy link
Collaborator

@alexfikl I think the CI tests are working now. I also squashed the commits and rebased.

Everything looks great! Thanks for the contribution ❤️
I've added a little unit test for it and will merge it in when it's done.

@alexfikl alexfikl merged commit b1f3961 into papis:master Apr 16, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants