Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for http URLs where filepaths are required (add --from bibtex and addto) #541

Merged
merged 7 commits into from
Apr 20, 2023

Conversation

f0rki
Copy link
Contributor

@f0rki f0rki commented Apr 18, 2023

Allows for two usecases:

  • papis addto -u https://example.com/paper.pdf paper
  • papis add --from bibtex https://example.com/paper.bib

papis/bibtex.py Fixed Show fixed Hide fixed
papis/commands/addto.py Fixed Show fixed Hide fixed
papis/commands/addto.py Dismissed Show dismissed Hide dismissed
papis/commands/addto.py Fixed Show fixed Hide fixed
papis/commands/addto.py Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ❤️

Left a couple of small nitpicks for the logger messages, but overall this looks nifty to me! Especially the addto change could be very useful.

papis/commands/addto.py Outdated Show resolved Hide resolved
papis/commands/addto.py Outdated Show resolved Hide resolved
papis/bibtex.py Outdated Show resolved Hide resolved
papis/bibtex.py Outdated Show resolved Hide resolved
papis/commands/addto.py Outdated Show resolved Hide resolved
@alexfikl
Copy link
Collaborator

Thanks for taking care of all the issues! In it goes 🚀

@alexfikl alexfikl changed the title Allow for http(s) URLs where currently filepaths are required (add --from bibtex and addto) Allow for http URLs where filepaths are required (add --from bibtex and addto) Apr 20, 2023
@alexfikl alexfikl merged commit 97f5431 into papis:master Apr 20, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants