-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for http URLs where filepaths are required (add --from bibtex
and addto
)
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
requested changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! ❤️
Left a couple of small nitpicks for the logger messages, but overall this looks nifty to me! Especially the addto
change could be very useful.
fixed messages of logger calls Co-authored-by: Alex Fikl <alexfikl@gmail.com>
alexfikl
approved these changes
Apr 20, 2023
Thanks for taking care of all the issues! In it goes 🚀 |
alexfikl
changed the title
Allow for http(s) URLs where currently filepaths are required (
Allow for http URLs where filepaths are required (Apr 20, 2023
add --from bibtex
and addto
)add --from bibtex
and addto
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for two usecases:
papis addto -u https://example.com/paper.pdf paper
papis add --from bibtex https://example.com/paper.bib