Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionItem.detail provides redundant information that is already provided in CompletionItem.kind #178

Closed
ericvw opened this issue Nov 19, 2021 · 1 comment · Fixed by #179

Comments

@ericvw
Copy link
Contributor

ericvw commented Nov 19, 2021

After #175 landed and evolved in 5488896, the ## <type> appended to the string is redundant with the information in the completion kind. Additionally, I noticed that it appears that ## statement only is rendered if the statement/variable doesn't have a type.

vim-jedi-lsp-redundant-kind

@pappasam, what are your thoughts? I'm happy to contribute a PR.

@ericvw
Copy link
Contributor Author

ericvw commented Nov 19, 2021

I created PR #179 that addresses the issue and provides some simplification for how the signatures are generated!

pappasam added a commit that referenced this issue Nov 19, 2021
Hover text requires more information embedded inside of it than other
types of information text. Completion items have more structured
information than Hover text. For this reason, structured information is
provided directly in Hover text and omitted from the signature (which is
used everywhere).

Fixes #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant