Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More infotext standardization #181

Closed
wants to merge 2 commits into from
Closed

Conversation

pappasam
Copy link
Owner

Standardize hover text and adjust signature accordingly

Hover text requires more information embedded inside of it than other
types of information text. Completion items have more structured
information than Hover text. For this reason, structured information is
provided directly in Hover text and omitted from the signature (which is
used everywhere).

Fixes #178

Hover text requires more information embedded inside of it than other
types of information text. Completion items have more structured
information than Hover text. For this reason, structured information is
provided directly in Hover text and omitted from the signature (which is
used everywhere).

Fixes #178
@pappasam
Copy link
Owner Author

@ericvw please test this out! If you think there are better ways to present this information across Hover, Completion, and Signature, I'm happy to consider any iterations in your PR as well

@ericvw
Copy link
Contributor

ericvw commented Nov 19, 2021

@pappasam, thanks. I'll take a look and report back.

@ericvw
Copy link
Contributor

ericvw commented Nov 19, 2021

Having jedi type: seems weird to me. I would call it type: because Jedi returns the canonical Python type names that type() would return.

The only other comment I have is the performance/slowness concerns I also raised in #179 (comment) when using get_type_hints(). It's not terrible in my testing, but it is definitely more noticeable compared to not using get_type_hints().

@pappasam
Copy link
Owner Author

Handled instead by #179 and cfd2e7a

@pappasam pappasam closed this Nov 19, 2021
@pappasam pappasam deleted the more-infotext-standardization branch November 19, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompletionItem.detail provides redundant information that is already provided in CompletionItem.kind
2 participants