Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a variety of fixes. #83

Merged
merged 53 commits into from
Jul 13, 2021
Merged

Conversation

hrmorley34
Copy link
Contributor

@hrmorley34 hrmorley34 commented Jul 4, 2021

Fixes:

  • Remove some texture names from TransparentBlocks
  • Add more blocks to TransparentBlocks
  • More helpful debug logging
  • Add RenderWall method
    • Fix cobblestone_wall
  • Add RenderPillar method
    • Fix hay, quartz/purpur pillar, bone block, wood/logs/stems/hyphae, basalt, deepslate
  • Add RenderPressurePlate method
  • Replace RenderFrame and RenderGlowItemFrame with the common RenderItemFrame
  • Add RenderFence method
  • Add RenderLantern method / partially fix lanterns
  • Fix RenderLightningRod method: shift up rod by one pixel
  • Add RenderEndRod method / fix end_rod
  • Fix RenderRail and rails
  • Correct sizes in RenderButton, RenderFence, and RenderFenceGate
  • Fix RenderFenceGate
  • Fix cake
  • Improve bed (fix direction and head/foot; not fixed colour)
  • Fix wood types
    • Fix planks, wooden_slab, fence, leaves, wood/logs
  • Fix smooth quartz stairs not being smooth
  • Fix flowers
  • Fix stonebrick and monster_egg types
  • Fix repeater, dispenser, observer, dropper directions
  • Fix end_portal_frame rotation and eye
  • Fix quartz_block chisel_type
  • Fix purpur_block chisel_type
  • Fix stonecutter texture
  • Fix all stone_slab(x) blocks' textures
  • Fix corals
  • Fix crops / add growth
  • Fix ancient_debris
  • Fix missing crimson/warped woods
  • Fix respawn_anchor
  • Partially fix sea_pickle
  • Fix wet sponges
  • Fix stone stone_type (granite, etc.)
  • Fix sand sand_type (red sand)
  • Fix chain from Fix issue #79: missing chain rendering #81
  • A few other things, probably

I may continue to update this branch further if I notice more things out-of-place.

bennydiamond and others added 30 commits June 8, 2021 21:08
Only render tip texture. Centered. Orientation fixed.
Will only render top and bottom facing texture.
TODO transform base texture and place for side facing lichen.
Will only render top and bottom facing texture.
TODO transform base texture and place for side facing lichen.
@bennydiamond
Copy link
Collaborator

Rebase on master please.

@hrmorley34
Copy link
Contributor Author

Could you clarify what exactly you mean by this?

Unfortunately I cannot easily rebase the branch because I have already merged in changes later and a lot of manual input would be unnecessarily required. I have already brought the branch up with merges to be not behind master.
Would you like a new, single commit like 74f9dbdc containing only diffs? If so, I have pushed a squashed commit to 80c094b5 containing all the same changes in one commit with the only parent as master.

@bennydiamond
Copy link
Collaborator

bennydiamond commented Jul 12, 2021

Could you clarify what exactly you mean by this?

Unfortunately I cannot easily rebase the branch because I have already merged in changes later and a lot of manual input would be unnecessarily required. I have already brought the branch up with merges to be not behind master.
Would you like a new, single commit like 74f9dbdc containing only diffs? If so, I have pushed a squashed commit to 80c094b5 containing all the same changes in one commit with the only parent as master.

The goal is to provide a pull request with a git history that represents the changes made. No matter, I will squash & merge it. But if it proves to break anything, I will outright revert it.

@bennydiamond bennydiamond merged commit 0f4cc4a into papyrus-mc:master Jul 13, 2021
@CrSjimo CrSjimo mentioned this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants