Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement g1_multiexp #31

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat: implement g1_multiexp #31

merged 1 commit into from
Apr 4, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Apr 2, 2024

Towards #11

Includes multiexp_required_gas which will be useful for gas calculation in g2_multiexp

@fgimenez fgimenez marked this pull request as ready for review April 3, 2024 19:05
@fgimenez fgimenez requested review from Rjected and mattsse April 3, 2024 19:07
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
I'm not too familiar with Bls, but all the operations seem sound to me.

pending @Rjected

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM! very clean

@fgimenez fgimenez merged commit 0e5e671 into main Apr 4, 2024
13 checks passed
@fgimenez fgimenez deleted the fgimenez/bls12-g1multiexp branch April 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants