Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement bls12 map_fp_to_g1 #36

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Apr 5, 2024

Towards #11

@fgimenez fgimenez requested review from Rjected and mattsse April 5, 2024 13:07
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests 👍

@fgimenez
Copy link
Member Author

fgimenez commented Apr 5, 2024

more tests 👍

indeed, all the precompiles come with their own test vectors file that is added as a case for the common test. For this precompile the file had fewer entries and was not collapsed in the diff view of the PR.

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgimenez fgimenez force-pushed the fgimenez/bls12-map-fp-to-g1 branch from e9a3d69 to 6ade808 Compare April 6, 2024 08:29
@fgimenez fgimenez merged commit 20195d5 into main Apr 6, 2024
13 checks passed
@fgimenez fgimenez deleted the fgimenez/bls12-map-fp-to-g1 branch April 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants