Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): transaction encoding and decoding #102

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 19, 2022

Adds methods for signed transaction encoding and for getting the signature hash for an unsigned transaction.
Tests to be tracked for a follow-up, this should fix clippy issues in the meantime

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending println cleanup

Comment on lines 459 to 460
println!("buf: {:x?}", buf);
println!("len: {:?}", buf.len());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup println

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yep whoops

@mattsse mattsse added the C-enhancement New feature or request label Oct 19, 2022
@Rjected Rjected changed the title feat(core): transaction encoding and decoding feat(primitives): transaction encoding and decoding Oct 19, 2022
@Rjected
Copy link
Member Author

Rjected commented Oct 19, 2022

Need to fix some broken things in revm_wrap.rs due to using TransactionKind

@Rjected Rjected merged commit 7e26ba5 into main Oct 19, 2022
@Rjected Rjected deleted the dan/primitives-encoding branch October 19, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants