feat(primitives): transaction encoding tests #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
force-pushed
the
dan/tx-encoding-tests
branch
from
1a9a6dc
to
cbc3541
Compare
mattsse
approved these changes
Oct 19, 2022
Comment on lines
762
to
757
| // let recovered = tx.recover().unwrap(); | ||
| // let expected: Address = "0xa12e1462d0ced572f396f58b6e2d03894cd7c8a4".parse().unwrap(); | ||
| // assert_eq!(expected, recovered); |
There was a problem hiding this comment.
we should uncomment this test once recovery is implemented. should that be in this PR or should we add an issue for it / do later?
There was a problem hiding this comment.
I see
should we add an issue for it
sgtm!
mattsse
added
C-enhancement
Rjected
force-pushed
the
dan/tx-encoding-tests
branch
from
cbc3541
to
8437413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests on top of #102 for signed transaction encoding and decoding
Changes
Signatureto useodd_y_parity: boolinstead of au8