perf: remove clones in PooledTransaction encoding

[Rjected]

Previously there were many clones in the Encodable implementation for PooledTransaction. This first adds a new method called payload_len_with_signature on the individual transaction types, making it usable by PooledTransaction variants. The method is then used in the Encodable::length implementation, and the encode_with_signature method is used for Encodable::encode.

Fixes #4243

[codecov]

Codecov Report

Merging #4251 (3d4e16c) into main (ca99ee2) will decrease coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 87.50%.

Files Changed	Coverage Δ
crates/primitives/src/transaction/pooled.rs	44.73% <64.70%> (-5.01%)	⬇️
crates/primitives/src/transaction/eip1559.rs	81.96% <100.00%> (+0.93%)	⬆️
crates/primitives/src/transaction/eip2930.rs	91.66% <100.00%> (+0.43%)	⬆️
crates/primitives/src/transaction/eip4844.rs	35.95% <100.00%> (+1.47%)	⬆️
crates/primitives/src/transaction/legacy.rs	100.00% <100.00%> (ø)
crates/primitives/src/transaction/mod.rs	80.04% <100.00%> (-0.07%)	⬇️

... and 16 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	16.88% <18.75%> (-0.03%)	⬇️
unit-tests	63.75% <87.50%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	26.13% <ø> (ø)
blockchain tree	82.56% <ø> (ø)
pipeline	90.07% <ø> (ø)
storage (db)	74.71% <ø> (ø)
trie	94.71% <ø> (ø)
txpool	49.03% <ø> (-1.67%)	⬇️
networking	77.46% <ø> (-0.05%)	⬇️
rpc	58.65% <ø> (+<0.01%)	⬆️
consensus	63.53% <ø> (ø)
revm	32.15% <ø> (ø)
payload builder	6.82% <ø> (ø)
primitives	86.31% <87.50%> (+0.08%)	⬆️