Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tmp pin nightly version #6435

Merged
merged 1 commit into from
Feb 6, 2024
Merged

ci: tmp pin nightly version #6435

merged 1 commit into from
Feb 6, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 6, 2024

latest nightly broke CI

https://github.com/paradigmxyz/reth/actions/runs/7793371136/job/21253001107?pr=6433

tmp pin toolchain to latest working version

@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Feb 6, 2024
@rswanson
Copy link
Collaborator

rswanson commented Feb 6, 2024

we should probably add a corresponding rust-toolchain.toml at the root of the repo if we're going to pin CI as well; otherwise the commands CI runs will break locally

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 6, 2024

we're not locked into nightly, but only use nightly for linting, formatting, docs

@mattsse mattsse merged commit dee1fae into main Feb 6, 2024
28 checks passed
@mattsse mattsse deleted the matt/pin-nightly-version branch February 6, 2024 02:06
@DaniPopes
Copy link
Member

DaniPopes added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants