Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump curve25519-dalek, revert nightly pin #6497

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Feb 8, 2024

Reverts #6435

@DaniPopes DaniPopes changed the title chore(deps): bump curve25519-dalek chore(deps): bump curve25519-dalek, revert nightly pin Feb 8, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we back

@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Feb 8, 2024
@mattsse mattsse added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit ac4b99a Feb 8, 2024
30 checks passed
@mattsse mattsse deleted the dani/unpin2 branch February 8, 2024 22:10
@wakamex
Copy link
Contributor

wakamex commented Feb 18, 2024

update at bottom I fixed it

I can't compile curve25519-dalek, am I doing something wrong?

I just followed my regular method of trying to build latest:

git pull main
RUSTFLAGS="-C target-cpu=native" cargo build --profile maxperf --features jemalloc

i'm on an amd processor on ubuntu 23.10

here's the error:

error[E0658]: use of unstable library feature 'stdsimd'
  --> /home/mihai/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.2/src/backend/vector/ifma/field.rs:26:5
   |
26 |     _mm256_madd52lo_epu64(z.into(), x.into(), y.into()).into()
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
   = help: add `#![feature(stdsimd)]` to the crate attributes to enable
   = note: this compiler was built on 2024-01-30; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'stdsimd'
  --> /home/mihai/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.2/src/backend/vector/ifma/field.rs:25:9
   |
25 |     use core::arch::x86_64::_mm256_madd52lo_epu64;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
   = help: add `#![feature(stdsimd)]` to the crate attributes to enable
   = note: this compiler was built on 2024-01-30; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'stdsimd'
  --> /home/mihai/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.2/src/backend/vector/ifma/field.rs:34:5
   |
34 |     _mm256_madd52hi_epu64(z.into(), x.into(), y.into()).into()
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
   = help: add `#![feature(stdsimd)]` to the crate attributes to enable
   = note: this compiler was built on 2024-01-30; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'stdsimd'
  --> /home/mihai/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.2/src/backend/vector/ifma/field.rs:33:9
   |
33 |     use core::arch::x86_64::_mm256_madd52hi_epu64;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
   = help: add `#![feature(stdsimd)]` to the crate attributes to enable
   = note: this compiler was built on 2024-01-30; consider upgrading it if it is out of date

error[E0635]: unknown feature `stdarch_x86_avx512`
  --> /home/mihai/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.2/src/lib.rs:19:13
   |
19 |     feature(stdarch_x86_avx512)
   |             ^^^^^^^^^^^^^^^^^^

   Compiling async-compression v0.4.6
   Compiling reth-nippy-jar v0.1.0-alpha.18 (/code/reth/crates/storage/nippy-jar)
   Compiling reth-node-core v0.1.0-alpha.18 (/code/reth/crates/node-core)
   Compiling reth-libmdbx v0.1.0-alpha.18 (/code/reth/crates/storage/libmdbx-rs)
   Compiling h2 v0.3.24
   Compiling tokio-stream v0.1.14
   Compiling delay_map v0.3.0
   Compiling reth-metrics v0.1.0-alpha.18 (/code/reth/crates/metrics)
   Compiling tower v0.4.13
Some errors have detailed explanations: E0635, E0658.
For more information about an error, try `rustc --explain E0635`.
error: could not compile `curve25519-dalek` (lib) due to 5 previous errors

EDIT: ah my rust was old rust and didn't have the latest shiznit, rustup update fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants