Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op): pass unverifiable ENRs to rlpx #8059

Merged
merged 8 commits into from
May 3, 2024
Merged

feat(op): pass unverifiable ENRs to rlpx #8059

merged 8 commits into from
May 3, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented May 2, 2024

Uses new discv5::Event::UnverifiableEnr to bridge CL and EL discv5 implementation

@emhane emhane added A-discv5 Related to discv5 discovery A-op-reth Related to Optimism and op-reth labels May 2, 2024
mattsse
mattsse requested changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jus some doc questions

crates/net/discv5/src/lib.rs Outdated Show resolved Hide resolved
crates/net/discv5/src/lib.rs Outdated Show resolved Hide resolved
Base automatically changed from emhane/discv5-visibility to main May 2, 2024 20:47
@emhane emhane requested a review from mattsse May 2, 2024 21:51
@emhane emhane requested a review from joshieDo May 3, 2024 11:06
joshieDo
joshieDo approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@joshieDo joshieDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple nits, but lgtm

did you notice an improvement ?

@emhane
Copy link
Member Author

emhane commented May 3, 2024 •
edited
Loading

just couple nits, but lgtm

did you notice an improvement ?

have haven't ran it. doesn't interfere with regular flow, and is purely an enhancement. so will not cause worse behaviour.

@emhane emhane enabled auto-merge May 3, 2024 13:10
@emhane emhane added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 1cf65e3 May 3, 2024
29 checks passed
@emhane emhane deleted the emhane/unverifiable-enr branch May 3, 2024 13:35
@emhane emhane mentioned this pull request May 8, 2024
Merged
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@emhane @mw2000
feat(op): pass unverifiable ENRs to rlpx (paradigmxyz#8059)
1373872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo joshieDo approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-discv5 Related to discv5 discovery A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emhane @mattsse @joshieDo