Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discv5): update metrics wrt unverifiable enrs #8149

Merged
merged 12 commits into from
May 8, 2024
Merged

fix(discv5): update metrics wrt unverifiable enrs #8149

merged 12 commits into from
May 8, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented May 8, 2024 •
edited

Screenshot 2024-05-08 at 13 25 51 Screenshot 2024-05-08 at 13 00 41

@emhane emhane added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools A-discv5 Related to discv5 discovery labels May 8, 2024
shekhirin
shekhirin approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, naming nit

@emhane emhane mentioned this pull request May 8, 2024
Closed
@emhane emhane enabled auto-merge May 8, 2024 11:31
@emhane emhane disabled auto-merge May 8, 2024 11:33
@emhane emhane enabled auto-merge May 8, 2024 11:34
@emhane emhane disabled auto-merge May 8, 2024 11:36
@emhane emhane enabled auto-merge May 8, 2024 11:37
@emhane emhane added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 6a6fe4c May 8, 2024
28 checks passed
@emhane emhane deleted the emhane/metrics-unverifiable-enr branch May 8, 2024 12:00
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@emhane @shekhirin @mw2000
fix(discv5): update metrics wrt unverifiable enrs (paradigmxyz#8149)
28343e1 
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-discv5 Related to discv5 discovery A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emhane @shekhirin