chore: add EnvironmentArgs and use across all CLI commands
#8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-debt
DaniPopes
approved these changes
Jun 4, 2024
shekhirin
approved these changes
Jun 4, 2024
onbjerg
approved these changes
Jun 4, 2024
mattsse
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--chain,--configand--datadirare all used to initiate an environment that a CLI command will use (config, providers etc).However, there's a lot of repetition with some commands missing some relevant flags. This PR attempts to fix that and dedup by adding a
EnvironmentArgsstruct that can initialize all the necessary context.Feel free to suggest other names other than Environment.
CliContextwas taken.Follow-up will be a version of #8553 , and probably moving
AccessRightsto reth_primitives since there's different versions of the same enum across crates.