Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check storage consistency on cli tools #8553

Closed
wants to merge 104 commits into from
Closed

feat: check storage consistency on cli tools #8553

wants to merge 104 commits into from

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jun 3, 2024 •
edited
Loading

wip follow-up to #8528

joshieDo and others added 30 commits May 7, 2024 18:34
@joshieDo
add StaticFileProvider::check_consistency
2070756
@joshieDo
Merge remote-tracking branch 'origin/main' into joshie/boot-up-check
a81ee6f
@joshieDo
use PipelineTarget::Unwind
65495fb
@joshieDo
Merge remote-tracking branch 'origin/main' into joshie/boot-up-check
d1ff55b
@joshieDo
generalize check_invariants and add docs
d8a44dd
@joshieDo
add NoopBlockExecutorProvider
e06334a
@joshieDo
check consistency on onLaunchContextWith::create_provider_factory
c820410
@joshieDo
Merge branch 'main' into joshie/boot-up-check
175680d
@joshieDo
pass config to unwind pipeline on create_provider_factory
5737636
@joshieDo
pass has_receipt_pruning to check_consistency
76c91f6
@joshieDo
missing arg
3aba5cc
@joshieDo
add docs
0d4a1ae
@joshieDo
docs and variable names
7aea4a8
@joshieDo
more docs
bd66959
@joshieDo
added ensure_file_consistency
6a8aab8
@joshieDo
add first test_check_consistency
1cb6009
@joshieDo
panic on unwind target to 0
d32cecb
@joshieDo
add warning to check_consistency
39a802a
@joshieDo
add read_only to check_consistency
50cead0
@joshieDo
make sure SegmentHeader is updated after file heal
aa865fa
@joshieDo
add early prune tests
67719b1
@joshieDo
nippyjar writer handle partial pruned row
f1502dd
@joshieDo
rename to test_consistency_no_commit_prune
98f1381
@joshieDo
fix usage of storage_kind on insert_blocks
a988e9e
@joshieDo
add checkpoint and gap tests
86946a6
@joshieDo
smol refactor on test functions
016deaa
@joshieDo
clippy
a0e3976
@joshieDo
nit
ea0ef7f
@joshieDo
add logs to node launch consistency check
d9fb353
@joshieDo
fmt
dfd2d8c
@joshieDo
change error msg
36fa1cf
@joshieDo
taken error takes pid
512fe83
@joshieDo
clippy
c3ad127
@joshieDo
Merge remote-tracking branch 'origin/main' into joshie/boot-up-check
477e027
@joshieDo
Merge branch 'joshie/boot-up-check' into joshie/storage-lock
51d6960
@joshieDo
use create_provider_factory in some cmds
6297b9c
@joshieDo
clean-up provider factory usage on cli tools
b2ebaa3
@joshieDo
Merge branch 'joshie/storage-lock' into joshie/cli-cons
ac53662
@joshieDo
re-add tempfile dep
3d1ef22
@joshieDo
update Cargo.lock
82b22df
@joshieDo
create lock dir if it doesn't exist
ce94241
@joshieDo
use std::fs and no as ref path
9d433dc
@joshieDo
rename to _lock_file
8a1341f
@joshieDo
add TODOs
3e59486
@joshieDo
clippy & todo
38a486e
@joshieDo
review fixes
f8f3f27
@joshieDo
fix fail_init_inconsistent_db
b177401
@joshieDo
Merge remote-tracking branch 'origin/main' into joshie/storage-lock
89137e1
@joshieDo
clippy
2ccf264
@joshieDo
Merge branch 'joshie/storage-lock' into joshie/cli-cons
8d7a219
@joshieDo
check sfp as well for read only
54fe619
@joshieDo joshieDo added A-db Related to the database A-cli Related to the reth CLI A-static-files Related to static files labels Jun 3, 2024
Base automatically changed from joshie/storage-lock to main June 3, 2024 12:42
@joshieDo joshieDo closed this Jun 4, 2024
@joshieDo joshieDo mentioned this pull request Jun 4, 2024
Merged
@joshieDo joshieDo deleted the joshie/cli-cons branch July 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita Awaiting requested review from rakita rakita will be requested when the pull request is marked ready for review rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin will be requested when the pull request is marked ready for review shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected will be requested when the pull request is marked ready for review Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-db Related to the database A-static-files Related to static files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshieDo