Make it work with gnome-shell 3.36 #564

shemgp · 2020-03-03T14:51:47Z

Well actually it's for GNOME Shell 3.35.91 still, but hopefully no more changes required for 3.36.

References for where I got hints for the fixes:

TipItem error (Tried to construct an object without a GType): http://gjs.guide/guides/gjs/transition.html#extending-gobject-classes
removal of raise_top: GNOME 3.35.2 Compatibility paperwm/PaperWM#212
Depreciated TableLayout: https://mail.gnome.org/archives/commits-list/2014-August/msg01899.html

rishabhpatel9 · 2020-03-04T20:19:24Z

Thank you! this works!

rishabhpatel9 · 2020-03-04T20:26:49Z

For some reason, I can't access the preferences anymore. neither is there a logo of the extension in applications. How do i fix that?

shemgp · 2020-03-05T04:44:51Z

Are you using Ubuntu Focal Fossa development? Because right now, preferences currently doesn't work for any extension on focal. I filed a bug report here: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1866146

…

On Thu, Mar 5, 2020 at 4:26 AM Rishabh Patel ***@***.***> wrote: For some reason, I can't access the preferences anymore. neither is there a logo of the extension in applications. How do i fix that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#564?email_source=notifications&email_token=AANHL3T62633TX2LJUAZ3OLRF22QVA5CNFSM4LAMERG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN2CZOI#issuecomment-594816185>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANHL3VGOCVXK7HSR2J4FHTRF22QVANCNFSM4LAMERGQ> .

chrisjbillington · 2020-03-08T16:20:05Z

Thanks works here on Arch!

Also can't access preferences from the context menu though. I can access preferences of other extensions through their context menus, and I access the system-monitor extension's preferences through gnome-tweaks.

velitasali · 2020-03-08T17:50:33Z

I don't think the problem with the preferences is related to the host. I can access the preferences of system-monitor with the new 'Extensions' app.

Thanks for the work.

d2r2 · 2020-03-09T13:05:03Z

Confirmed. This works on Arch. Thanks!
Update: @shemgp, button "Preferences..." from the widget doesn't work, but preferences window can be opened from Tweaks app.

AlexWayfer · 2020-03-09T13:16:17Z

You can mark this PR as resolving #559.

hadim · 2020-03-10T00:30:20Z

Thanks for this PR! I am waiting for it.

shemgp · 2020-03-10T02:50:50Z

Preferences menu should work now. I tested it on GNOME 3.36.0.

d2r2 · 2020-03-10T06:05:18Z

Preferences menu should work now. I tested it on GNOME 3.36.0.

Confirmed. Preference menu works from widget after update! @shemgp, thanks a lot!

vltr · 2020-03-11T09:37:52Z

This PR works, even though the size of each graph on display doesn't respect the size set (initially) on settings:

Going to the settings and resetting the value to 40 (in my case, by clicking + and -) makes it works properly (until next login):

shemgp · 2020-03-11T15:35:53Z

@vltr It does remember the values for me and upon looking at the code, it should too. Perhaps you could try resetting the system-monitor folder in dconf-editor, or running make install in the checkout of this repo.

vltr · 2020-03-12T15:41:57Z

@shemgp did that (from your branch), no luck 😬 my extension is installed locally. I'll play around with some other extensions to see if any of them may be causing this ... Because, well, I just got "Gnome'd" again 😅

vltr · 2020-03-12T15:52:39Z

@shemgp update: it does work properly if compact display is off. When on, it gives me the behavior I mentioned earlier. Weird ...

shemgp · 2020-03-12T15:59:28Z

@vltr Compact display compacts the width by 1.5 so maybe like me, you thought it's not remembering it, when actually it's just compacting it. Try putting, eg., 100 on only one of them and see that it's still wider than the others even in compact mode and when restarted.

vltr · 2020-03-12T20:08:47Z

@shemgp wrong assumption made by me, then. All I thought it did was appending -compact to the CSS classes ... Maybe at one point, I don't know. Sorry for the misunderstanding 😐

suiryc · 2020-03-12T21:39:56Z

@vltr I confirm that the behaviour appears to have changed as you though.

In gnome 3.34, the non-compact mode looks like this (bar and text):

The compact mode does shrink the text and the space between graphs in the bar:

Now in gnome 3.36, the compact mode starts like this in the bar:

And as you said, simply doing "+1" "-1" for each graph in the preferences (still in compact mode) does resize them to what we had in 3.34 (until you restart the session):

shemgp · 2020-03-13T09:33:12Z

@suiryc, I made the resize ([+] and [-]) work the same as when loading, for this PR anyway, as I think that's the intention of the original developers: To compact the width too when compact is set. It's just that on resize, they forgot to make it compute the compacted width.

If you want to have the same width as the non-compact mode when on compact mode, you'll just have to multiply the size by 1.5.

suiryc · 2020-03-13T13:49:52Z

Maybe.
The previous behaviour has been there for some time now (have been using this extension for a few years).

I am not sure either of what the majority of people using this extension expect when dealing with 'graph width' and 'refresh rate'.

Depending on the intent the new behaviour makes it a bit harder to configure.
Previously it was easy to configure the 'history length' to display in the graph: e.g. a width of N with a refresh rate of 2s would give N*2s of history. And having compact mode or not had no impact on that.
Now depending on the mode there would be the 1.5 factor to apply or not. Hoping this hard-coded value won't change too much in the future then 😉

zegkljan · 2020-03-18T07:36:00Z

I was using the version from this PR for some time (ever since gnome-shell 3.36 started rolling out on archlinux) and everything was quite fine up until today when it stopped working. The error I get is

JS ERROR: Extension system-monitor@paradoxxx.zero.gmail.com: Error: Tried to construct an object without a GType; are you using GObject.registerClass() when inheriting from a GObject type?
SystemMonitor_TipItem@/home/zegkljan/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:635:9
tip_format@/home/zegkljan/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:898:27
SystemMonitor_Cpu@/home/zegkljan/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:1191:14
createCpus@/home/zegkljan/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:1353:24
enable@/home/zegkljan/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:2286:26
_callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26
activate@/home/zegkljan/.local/share/gnome-shell/extensions/extension-reloader@nls1729/extension.js:112:34
vfunc_button_release_event@resource:///org/gnome/shell/ui/popupMenu.js:138:14

I would be thrilled to help (I can't imagine life without this extension), if instructed because I know literally nothing about how gnome-shell extensions work and how are they developed.

I'm running on gnome-shell 3.36.0 on wayland on archlinux.

shemgp · 2020-03-18T10:31:15Z

@zegkljan There's no more SystemMonitor_TipItem in this PR. Please make sure you're using this PR.

zegkljan · 2020-03-18T11:47:03Z

@shemgp Sorry, I'm an idiot. I did not checkout the correct branch. Everything works.

DmitryBurstein · 2020-04-08T05:36:52Z

I'm getting the following on F32 beta with gnome-shell-3.36.1-2.fc32.x86_64:
Error: Tried to construct an object without a GType; are you using GObject.registerClass() when inheriting from a GObject type?

shemgp · 2020-04-08T05:47:28Z

@DmitryBurstein Please make sure you git checkout gnome-shell-3.36 before running make install?

DmitryBurstein · 2020-04-08T05:52:09Z

The Makefile I run was inside ~/gnome-shell-system-monitor-applet-gnome-shell-3.36/, so I hope it was the right one.
Anyways, the .local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js file does include "var GObject = imports.gi.GObject;" and everything else you've changed there.

shemgp · 2020-04-08T05:57:08Z

@DmitryBurstein Here's how to install this PR:

git clone https://github.com/shemgp/gnome-shell-system-monitor-applet.git
cd gnome-shell-system-monitor-applet
git checkout gnome-shell-3.36
make install

Then restart gnome-shell.

DmitryBurstein · 2020-04-08T06:08:43Z

Great, thanks a lot! Now, after a log off/on cycle, everything is working again. Many thanks for your help!

danielquinn · 2020-04-09T12:37:45Z

This PR is beginning to devolve into a howto manual for installing this branch rather than fixing an incompatibility. What exactly is the hold up for pushing this out to extensions.gnome.org?

AllesMeins · 2020-04-10T08:52:04Z

What exactly is the hold up for pushing this out to extensions.gnome.org?

I second this - since installing manually also has the problem that I'd have to deactivate automatic updates - otherwise the extension is reverted to the old non-functioning one after each reboot.

joshlangley · 2020-04-10T20:59:36Z

@AllesMeins, I personally used a quick and dirty fix for this by making ~/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/ a read-only folder using sudo. It essentially prevents any modification of only that extension. Again, quick and dirty. I too think this should get pushed.

leinardi · 2020-04-10T22:36:21Z

This is great, thank you.
Only problem is that GNOME thinks the latest published version is newer than this, and automatically downloads it to ~/.local/share/gnome-shell/extension-updates and applies it when the shell is restarted.
Currently I work around the auto-update by explicitly specifying the version number, i.e., make install VERSION=39 (latest published version is 38 at the time of writing). Is there a less hackish way to do this?

@AllesMeins @ElSenor64 this seems to work for me and I think is better than changing file permissions.

will-ca · 2020-04-11T07:02:08Z

I'd like to again point out that the immediately preceding two comments— that (1) any discussion about developing this PR quickly devolves into instructions for manually installing it, and (2) the people who do install it manually seem to report no continued incompatibilities— seem to illustrate both that there is a considerable user demand for pushing this into the main branch and that it is ready to be released from there.

AllesMeins · 2020-04-12T22:28:06Z

seem to illustrate both that there is a considerable user demand

And there will be even more in less then ten days when Ubuntu 20.04 is released and the current version of the extension will break for everybody doing the upgrade.

franglais125 · 2020-04-13T02:22:08Z

Rebased and merged. It would be great if additional testing could be done, for feedback. In case any regression might have sneaked in.

sideeffffect · 2020-04-13T11:44:07Z

could you please make a release that contains this fix? 🙏

AlexWayfer · 2020-04-13T11:58:45Z

Rebased and merged. It would be great if additional testing could be done, for feedback. In case any regression might have sneaked in.

"Preferences..." in the extension's drop-down menu opens extensions window. Is it expected?

shemgp · 2020-04-13T12:47:46Z

@AlexWayfer should be fixed by #576

AlexWayfer · 2020-04-13T13:51:24Z

@AlexWayfer should be fixed by #576

Thank you!

will-ca · 2020-04-16T03:57:29Z

...Does anyone know who maintains the upload on extensions.gnome.org, and whether, when, or how it might be updated to reflect this patch?

Aside from the lack of automatic updating, requiring a separate manual installation also fragments the userbase, and has already confused many people and will likely soon confuse many more if a new Ubuntu release is indeed going to imminently break this extension for hundreds or thousands of users.

franglais125 · 2020-04-16T04:05:02Z

@will-ca and everyone:

@chrisspen is taking care of this, and offers his time for free to do so responsibly. So let's please be patient.

Every time there is a new Gnome Shell release, lots of bugs pop up everywhere, with mixed reports. It's hard to track all the possible configuration mishaps (distros, versions, patched distros, etc.) To address this, look at some of the work he is proposing in the docker branch.

Whenever this new version will be ready for shipping, it's better to get it right.

Believe me, I do understand the frustration: I use myself other extensions and am in the same position as you.

Cheers everyone. And thank you @chrisspen for maintaining this extension for a few years already.

gerstrong · 2020-04-16T18:44:52Z

Yes, this works for me :-)

ciltocruz · 2020-04-26T14:20:54Z

Finally this method has worked correctly.

Thanks to the developers.

However, this is not yet available from the GNOME extension panel web page.

A greeting.

Fixing "TypeError: this.actor.reparent is not a function", with reference from paradoxxxzero/gnome-shell-system-monitor-applet#564 "Make it work with gnome-shell 3.36"

shemgp added 2 commits March 3, 2020 22:44

Make it work with gnome-shell 3.36

7906bc2

style fixes

69fe158

d2r2 mentioned this pull request Mar 9, 2020

extension doesn't load/work with gnome 3.35.x. #559

Open

shemgp added 2 commits March 10, 2020 10:41

be able to show preferences from menu

c62da61

style fixes

f7eef87

aminvakil mentioned this pull request Mar 10, 2020

Update for gnome 3.36 ? rostegg/public-ip-gnome-extension#15

Closed

make compact work even on resize

07ca28b

mcardillo55 mentioned this pull request Mar 19, 2020

Updates for Gnome 3.36 #568

Closed

Use UPower directly to remove warning

c9588e5

andrevandal mentioned this pull request Apr 6, 2020

Error: Tried to construct an object without a GType fffilo/prime-indicator#6

Closed

franglais125 closed this Apr 13, 2020

shemgp mentioned this pull request Apr 13, 2020

Fix: use latest way to call preferences #576

Merged

franglais125 mentioned this pull request Apr 21, 2020

Expand build process to test applet in Docker #577

Open

joshlangley mentioned this pull request Apr 21, 2020

Does not work on GNOME 3.36 sgaraud/gnome-extension-show-ip#35

Open

This was referenced Apr 27, 2020

Latest release fails to install with Tried to construct an object without a GType #596

Closed

Tried to construct an object without a GType; are you using GObject.registerClass() when inheriting from a GObject type? #575

Open

raginggoblin mentioned this pull request Nov 16, 2020

Failed to load on 3.38 atareao/microphone-loopback#3

Open

Make it work with gnome-shell 3.36 #564

Make it work with gnome-shell 3.36 #564

Conversation

shemgp commented Mar 3, 2020

rishabhpatel9 commented Mar 4, 2020

rishabhpatel9 commented Mar 4, 2020

shemgp commented Mar 5, 2020 via email

chrisjbillington commented Mar 8, 2020

velitasali commented Mar 8, 2020

d2r2 commented Mar 9, 2020 • edited Loading

AlexWayfer commented Mar 9, 2020

hadim commented Mar 10, 2020

shemgp commented Mar 10, 2020 • edited Loading

d2r2 commented Mar 10, 2020

vltr commented Mar 11, 2020

shemgp commented Mar 11, 2020

vltr commented Mar 12, 2020

vltr commented Mar 12, 2020

shemgp commented Mar 12, 2020

vltr commented Mar 12, 2020

suiryc commented Mar 12, 2020

shemgp commented Mar 13, 2020

suiryc commented Mar 13, 2020

zegkljan commented Mar 18, 2020

shemgp commented Mar 18, 2020

zegkljan commented Mar 18, 2020

DmitryBurstein commented Apr 8, 2020

shemgp commented Apr 8, 2020

DmitryBurstein commented Apr 8, 2020 • edited Loading

shemgp commented Apr 8, 2020 • edited Loading

DmitryBurstein commented Apr 8, 2020

danielquinn commented Apr 9, 2020

AllesMeins commented Apr 10, 2020 • edited Loading

joshlangley commented Apr 10, 2020

leinardi commented Apr 10, 2020 • edited Loading

will-ca commented Apr 11, 2020

AllesMeins commented Apr 12, 2020

franglais125 commented Apr 13, 2020

sideeffffect commented Apr 13, 2020

AlexWayfer commented Apr 13, 2020

shemgp commented Apr 13, 2020

AlexWayfer commented Apr 13, 2020

will-ca commented Apr 16, 2020 • edited Loading

franglais125 commented Apr 16, 2020

gerstrong commented Apr 16, 2020

ciltocruz commented Apr 26, 2020

d2r2 commented Mar 9, 2020 •

edited

Loading

shemgp commented Mar 10, 2020 •

edited

Loading

DmitryBurstein commented Apr 8, 2020 •

edited

Loading

shemgp commented Apr 8, 2020 •

edited

Loading

AllesMeins commented Apr 10, 2020 •

edited

Loading

leinardi commented Apr 10, 2020 •

edited

Loading

will-ca commented Apr 16, 2020 •

edited

Loading