Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backward support for Gnome 3.28 , fix NaN temperature and disk IO… #674

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

bluet
Copy link
Contributor

@bluet bluet commented Apr 6, 2021

… on Ubuntu 18.04

add backward support for Gnome 3.28 , fix NaN temperature and disk IO on Ubuntu 18.04 .

related issues: #520 #526 #594 #597 #601 thankjura/ds4battery#4
I don't have dedicated GPU to test #592 but it should be possible to fix in the same way.

inspired by @shemgp and @EBoisseauSierra

… on Ubuntu 18.04

add backward support for Gnome 3.28 , fix NaN temperature and disk IO on Ubuntu 18.04 . 

related issues: paradoxxxzero#520 paradoxxxzero#526 paradoxxxzero#594 paradoxxxzero#597 paradoxxxzero#601  thankjura/ds4battery#4  
I don't have dedicated GPU to test paradoxxxzero#592 but it should be possible to fix in the same way.

inspired by @shemgp and @EBoisseauSierra
@bluet
Copy link
Contributor Author

bluet commented Apr 6, 2021

Result (3.28)
2021-04-06 17-45-04 的螢幕擷圖

@chrisspen chrisspen merged commit 2dc6dbd into paradoxxxzero:master Apr 6, 2021
@chrisspen
Copy link
Collaborator

Thank you.

@Tutorgaming
Copy link

in my machine, it still shows NaN as output (Thinkpad T490 + Ubuntu 18.04 + Gnome Shell 3.28.4)
But when I use the combination between Math.round and parseFloat (instead of parseInt) it works as it should be.

I'm not sure if it is machine-dependent or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants