Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Localhost database host UX Setup Issue #54

Closed
1 task
co60ca opened this issue Jun 30, 2016 · 5 comments
Closed
1 task

Localhost database host UX Setup Issue #54

co60ca opened this issue Jun 30, 2016 · 5 comments

Comments

@co60ca
Copy link
Contributor

co60ca commented Jun 30, 2016

  • Check this box if this is a security vulnerability.

Summary

If you are using localhost as a database host it will give

Could not create a database connection. Please check your username and password.

if you do not replace the placeholder value of localhost with the word localhost or any loopback.

This is more of a UX issue than a bug IMHO but I think most would assume if the placeholder is there you don't have to fill it in. I suppose your use of "(optional)" on Port should indicate that all other fields are required, but this isn't super user friendly.

Expected Outcome

It should use localhost anyway, perhaps set the value of database_0_host's input to localhost instead of the placeholder, or set a default on the backend to try localhost if the field isn't set.

What Actually Happened

Returns to credential screen

Relevant Debug Information

@co60ca co60ca changed the title Potential Bug - Localhost database host Localhost database host UX Setup Issue Jun 30, 2016
@paragonie-scott
Copy link
Member

perhaps set the value of database_0_host's input to localhost instead of the placeholder, or set a default on the backend to try localhost if the field isn't set.

That should already be happening. I'll look at it right now.

@co60ca
Copy link
Contributor Author

co60ca commented Jul 1, 2016

I pulled the master branch before building with docker.

paragonie-security added a commit that referenced this issue Jul 1, 2016
@paragonie-scott
Copy link
Member

Can you tell me if 56417c7 fixes this for you? localhost is the default here.

@paragonie-scott
Copy link
Member

paragonie-scott commented Jul 1, 2016

Off-topic: I wish I could let people select their own issue labels.

@paragonie-scott paragonie-scott added this to the Version 1.1.0 milestone Jul 1, 2016
@co60ca
Copy link
Contributor Author

co60ca commented Jul 1, 2016

Confirmed the fix in 56417c7

@co60ca co60ca closed this as completed Jul 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants