Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup. #104

Merged
merged 21 commits into from
Mar 27, 2018
Merged

Cleanup. #104

merged 21 commits into from
Mar 27, 2018

Conversation

Nenglish7
Copy link
Contributor

Random Audit

  • Don't use fallback in global scope

Halite Alerts

  • Delete empty lines that are not necessary.
  • Delete "code coverage ignore" since a class with no methods is automatically ignored.
  • Give it an overall clean look.

@Nenglish7
You are already in a global scope.
66dfcdf
@Nenglish7
Cleanup clone alert.
3e04609 
- Delete empty lines that are not necessary.
- Delete code coverage ignore since a class with no methods is automatically ignored.
- Give it an overall clean look.
@Nenglish7
Update CannotPerformOperation.php
5f12297
@Nenglish7
Cleanup cannot preform operation alert.
6869518 
- Delete empty lines that are not necessary.
- Delete code coverage ignore since a class with no methods is automatically ignored.
- Give it an overall clean look.
@Nenglish7
Update CannotSerializeKey.php
5287262
@Nenglish7
Update CannotPerformOperation.php
3e39911
@Nenglish7
Update ConfigDirectiveNotFound.php
82c050d
@Nenglish7
Update FileAccessDenied.php
228faee
@Nenglish7
Update FileError.php
f2a621f
@Nenglish7
Update FileModified.php
bcce691
@Nenglish7
Update HaliteAlert.php
bf78d45
@Nenglish7
Update InvalidDigestLength.php
fec250f
@Nenglish7
Update InvalidFlags.php
987a008
@Nenglish7
Update InvalidKey.php
6551a92
@Nenglish7
Update InvalidMessage.php
d687e5a
@Nenglish7
Update InvalidSalt.php
6bb9bba
@Nenglish7
Update InvalidSignature.php
0c58cf7
@Nenglish7
Update InvalidType.php
80981a6
@Nenglish7
Create HaliteAlertInterface.php
2b249dd
@Nenglish7
Update HaliteAlertInterface.php
abb227c
@Nenglish7
Fix error.
ad55935
@coveralls
Copy link

coveralls commented Mar 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 664

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.855%
Totals Coverage Status
Change from base Build 660: 0.0%
Covered Lines: 1375
Relevant Lines: 1377
💛 - Coveralls

@paragonie-scott
Copy link
Member

Coveralls' indicator icon is hanging. But it passed.

@paragonie-scott paragonie-scott merged commit 2b1b510 into paragonie:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nenglish7 @coveralls @paragonie-scott