Merge pull request #74 from LeSuisse/value-by-ref-php-libsodium-1.x

Ensure sodium_memzero() wipe the string when libsodium-php 1.x is used
paragonie · Aug 29, 2018 · 527e0a9 · 527e0a9
2 parents bdf8b34 + cb9a155
commit 527e0a9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Compat.php b/src/Compat.php
@@ -2592,8 +2592,11 @@ public static function memzero(&$var)
             return;
         }
         if (self::use_fallback('memzero')) {
-            @call_user_func('\\Sodium\\memzero', $var);
-            return;
+            $func = '\\Sodium\\memzero';
+            $func($var);
+            if ($var === null) {
+                return;
+            }
         }
         // This is the best we can do.
         throw new SodiumException(