Ensure sodium_memzero() wipe the string when libsodium-php 1.x is used #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the value by reference to \Sodium\memzero() and ensure the value seems to have been wiped to not silent an issue. Related to paragonie#73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the value by reference to \Sodium\memzero() and ensure the value seems to have been wiped to not silent an issue.
This is related to #73.
Using the same strategy with
\Sodium\increment()or variants of it withcall_user_func_array()orReflectionFunction::invokeArgs()does not seem to work. I'm not quite sure why at the moment.