Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize error message #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gabrielgrant
Copy link

fixes #40

set version to 2.4.2 (latest) since version 2.1.6 doesn't build:

node_modules/@types/lodash/index.d.ts(9240,74): error TS2304: Cannot find name 'object'.
node_modules/@types/lodash/index.d.ts(13129,29): error TS2304: Cannot find name 'object'.
node_modules/@types/lodash/index.d.ts(20002,33): error TS2304: Cannot find name 'object'.
@gabrielgrant
Copy link
Author

FWIW this is based off the branch in #37, since compiling doesn't seem to work without those fixes

@paralin
Copy link
Owner

paralin commented Aug 16, 2017

I'm going to make some pretty pedantic change requests. Let me know if you don't want to do some of them, and I can patch it up myself today or tomorrow. But don't feel too annoyed about how minor these changes are :)

@gabrielgrant
Copy link
Author

No worries, fire away :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC Error message is not returned to client
2 participants