Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsPDF loading issue with EmberJS #905

Closed
tzhbami7 opened this issue Oct 12, 2016 · 8 comments
Closed

jsPDF loading issue with EmberJS #905

tzhbami7 opened this issue Oct 12, 2016 · 8 comments

Comments

@tzhbami7
Copy link

Hey there,

I've tried to import jsPDF into my Ember App but sadly without any success :/

Are you using the latest version of jsPDF?
"version": "1.3.2"

Steps to reproduce
I have importet jspdf.debug.js like described at https://guides.emberjs.com/v2.0.0/addons-and-dependencies/managing-dependencies/#toc_globals-provided-by-javascript-assets

app.import('bower_components/jspdf/dist/jspdf.debug.js');

What I saw
Uncaught Error: an unsupported module was defined, expected define(name, deps, module) instead got: 1 arguments to define

I've tried to extend the define() call in jspdf.debug.js but it seems that I'm doing it at the wrong place...

`

  jsPDF.API = { events: [] };
  jsPDF.version = "1.3.2 2016-09-30T20:33:17.116Z:jameshall";

  if (typeof define === 'function' && define.amd) {
      // INFO: I've added [] to the call down here
      define('jsPDF', [], function () {
          return jsPDF;
      });
  } else if (typeof module !== 'undefined' && module.exports) {
      module.exports = jsPDF;
  } else {
      global.jsPDF = jsPDF;
  }
  return jsPDF;

`

Any help would be highly appreciated.

Cheers,
Michael

@HaithamMaya
Copy link

I'm getting the same error. Had to revert back to 1.2.61

@MrRio
Copy link
Member

MrRio commented Oct 17, 2016

Strange, we changed to rollup since the 1.2.x releases. It's got something to do with that. Will take a look.

@michaellee
Copy link

I seem to be getting the same issue with v1.3.2 has there been any solutions to getting this to work?

@blackknight467
Copy link

Same issue here v1.3.2

@wviveiro
Copy link

wviveiro commented May 26, 2017

I found the problem, however it is in a third party dependency:

File: node_modules/adler32cs/adler32cs.js

image

define(callback) should be define([], callback)

image

This repo https://github.com/chick307/adler32cs.js hasn't had any contribution for 4 years though....

@avblink
Copy link

avblink commented Aug 30, 2017

Should it not then be forked and link in jsPDF package.json file pointed to the fork?
Just wandering about the best approach to getting it to work.

dusanstanojeviccs added a commit to dusanstanojeviccs/jsPDF that referenced this issue Nov 9, 2017
adler32cs is no longer maintained, made package.json point to my fork of  adler32cs that contains the loader.js fix
@dusanstanojeviccs
Copy link
Contributor

If you are using Ember (loader.js) and want the version 1.3.5 of jspdf here is the minified version of my pull request #1514

https://gist.githubusercontent.com/dusanstanojeviccs/e72bcb0221cc71afd79f17cc0d2909ec/raw/321445afbac6e2ef3811a3ee07f6ec09af4ad0aa/jspdf.min.js

@MrRio
Copy link
Member

MrRio commented Dec 12, 2017

Fix in #1514

@MrRio MrRio closed this as completed Dec 12, 2017
Uzlopak added a commit that referenced this issue Feb 22, 2018
* Update karma.conf.js

* Merge  (#7)

* Update addimage.js

Solution to solve memory leaks caused by big images.
Is solving the issues #844 and #425

* normalize Color Methods

* f2 => f3

* make it black

* make it gray again

typeof comparison was wrong...

* make typeof comparison wrong to pass test

* Update jspdf.js

d'oh

* Update jspdf.js

correct it again....

* operation fix

ch1 === ch2  === ch3 is wrong. it would process from left to right resulting in a ch1 === ch2 => true, true === ch3 => false

* update test pdf

fix it so that the test is passed

* Update rectangles.pdf

stupid letter

* Update rectangles.pdf

fix length of content

* Update rectangles.pdf

... why?

* Update jspdf.js

DRY it up
add cssColor to rgb  conversion

* Update jspdf.js

bugfix

* Update standard.spec.js

add test for colornames

* Update standard.spec.js

* Update standard.spec.js

* Update jspdf.js

convert short rgb to long form

* Update standard.spec.js

add test case for short rgb-values

* Update jspdf.js

add a setter for the CreationDate

* Update jspdf.js

some major changes to the setCreationDate Algorythm

* Update jspdf.js

bugfix

* Update jspdf.js

darn...

* Update jspdf.js

* Update jspdf.js

* Update jspdf.js

bugfix

* Update addimage.js

round is not the proper method. It has to be ceil so that the splice-method is called atleast once.

* add polyfill for Object.assign

* Add files via upload

* Add files via upload

fix small mistake

* fix tainted standardfontsmetrics

* Add files via upload

one fix

* Update acroform.js

* update references

* modify tests

* force testing

* Update acroform.js

* Add files via upload

* Update acroform.js

* update references

* Add files via upload

* Update acroform.js

* Update acroform.js

* Add files via upload

* Update acroform.js

* Add files via upload

* Add files via upload

* Update acroform.js

* Add files via upload

* addimage.js add cmyk recognition for jpg

* make it less code

* Update saucelabs.karma.conf.js

* Create standard.spec.js

* Create jpg.pdf

* Rename tests/addimage/jpg.pdf to tests/addimage/reference/jpg.pdf

* Add files via upload

* test first if jpeg is working

* Add files via upload

* Update jpeg.spec.js

* Add files via upload

* Add files via upload

* Add files via upload

* Update saucelabs.karma.conf.js

* Update jpg.b64

* Update addhtml.js

#1480

* add ability to recognize filetype by header

* remove unnecessary variable

* typo-fix

* Update addimage.js

* Update addimage.js

#966

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

* Update saucelabs.karma.conf.js

* Update compare.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

* Add files via upload

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update compare.js

D'Oh

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

why is here a done? fml

* Add files via upload

* Add files via upload

* Add files via upload

* Delete jpg.b64

* Update jpeg.spec.js

* Update compare.js

* Update saucelabs.karma.conf.js

* Update png.spec.js

* Update saucelabs.karma.conf.js

* Update addimage.js

* Create filetypeRecognition.spec.js

* Update saucelabs.karma.conf.js

* Update filetypeRecognition.spec.js

* Update addimage.js

* fix IE error

* Update standard.spec.js

HideWindowUI.pdf is misssing

* compare.js make it look good

* add tests

* Update saucelabs.karma.conf.js

* Fix for #905 #1163 #1317

adler32cs is no longer maintained, made package.json point to my fork of  adler32cs that contains the loader.js fix

* small modification

* Update outline.js

* Add files via upload

* Update standard.spec.js

* Update karma.conf.js to load outline.js

* Update saucelabs.karma.conf.js to load outline.js

* chore(package): update rollup-plugin-babel to version 3.0.3

* chore(package): update karma to version 2.0.0

* Add new method for internal, getTextColor

* Update dist files and docs to include getTextColor

* Revise getTextColor to return hex code; add new spec

* Compiled assets for getTextColor modifications

* Updates spec and documentation per feedback

* chore(package): update uglify-js to version 3.3.5

Closes #1506

* simplify

* addCreationDate

* Update standard.spec.js

* Update standard.spec.js

* Update jspdf.js

* Update standard.spec.js

* Update standard.spec.js

* Add png adam7 interlace (#6)

* Update png.js

Adapted from here 
foliojs/png.js#8

* make it look good

* fix possible merging error

* fix minor bug

* hopefull removed all dupes

* Update main.js

* Don't skip HideWindowUI

* Update addimage.js

* Update compare.js

* Add files via upload

* Update jspdf.js

* Update jspdf.js

* Update addhtml.js

* Update outline.js

* Update cell.js

* Update annotations.js

* Update from_html.js

* Update context2d.js

* Update acroform.js

* Update addimage.js

* Update karma.conf.js

* Create getImageProperties.spec.js

* typo
Uzlopak added a commit that referenced this issue May 8, 2018
* Update karma.conf.js

* Merge  (#7)

* Update addimage.js

Solution to solve memory leaks caused by big images.
Is solving the issues #844 and #425

* normalize Color Methods

* f2 => f3

* make it black

* make it gray again

typeof comparison was wrong...

* make typeof comparison wrong to pass test

* Update jspdf.js

d'oh

* Update jspdf.js

correct it again....

* operation fix

ch1 === ch2  === ch3 is wrong. it would process from left to right resulting in a ch1 === ch2 => true, true === ch3 => false

* update test pdf

fix it so that the test is passed

* Update rectangles.pdf

stupid letter

* Update rectangles.pdf

fix length of content

* Update rectangles.pdf

... why?

* Update jspdf.js

DRY it up
add cssColor to rgb  conversion

* Update jspdf.js

bugfix

* Update standard.spec.js

add test for colornames

* Update standard.spec.js

* Update standard.spec.js

* Update jspdf.js

convert short rgb to long form

* Update standard.spec.js

add test case for short rgb-values

* Update jspdf.js

add a setter for the CreationDate

* Update jspdf.js

some major changes to the setCreationDate Algorythm

* Update jspdf.js

bugfix

* Update jspdf.js

darn...

* Update jspdf.js

* Update jspdf.js

* Update jspdf.js

bugfix

* Update addimage.js

round is not the proper method. It has to be ceil so that the splice-method is called atleast once.

* add polyfill for Object.assign

* Add files via upload

* Add files via upload

fix small mistake

* fix tainted standardfontsmetrics

* Add files via upload

one fix

* Update acroform.js

* update references

* modify tests

* force testing

* Update acroform.js

* Add files via upload

* Update acroform.js

* update references

* Add files via upload

* Update acroform.js

* Update acroform.js

* Add files via upload

* Update acroform.js

* Add files via upload

* Add files via upload

* Update acroform.js

* Add files via upload

* addimage.js add cmyk recognition for jpg

* make it less code

* Update saucelabs.karma.conf.js

* Create standard.spec.js

* Create jpg.pdf

* Rename tests/addimage/jpg.pdf to tests/addimage/reference/jpg.pdf

* Add files via upload

* test first if jpeg is working

* Add files via upload

* Update jpeg.spec.js

* Add files via upload

* Add files via upload

* Add files via upload

* Update saucelabs.karma.conf.js

* Update jpg.b64

* Update addhtml.js

#1480

* add ability to recognize filetype by header

* remove unnecessary variable

* typo-fix

* Update addimage.js

* Update addimage.js

#966

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

* Update saucelabs.karma.conf.js

* Update compare.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

* Add files via upload

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update compare.js

D'Oh

* Update compare.js

* Update jpeg.spec.js

* Update compare.js

* Update compare.js

* Update compare.js

* Update jpeg.spec.js

why is here a done? fml

* Add files via upload

* Add files via upload

* Add files via upload

* Delete jpg.b64

* Update jpeg.spec.js

* Update compare.js

* Update saucelabs.karma.conf.js

* Update png.spec.js

* Update saucelabs.karma.conf.js

* Update addimage.js

* Create filetypeRecognition.spec.js

* Update saucelabs.karma.conf.js

* Update filetypeRecognition.spec.js

* Update addimage.js

* fix IE error

* Update standard.spec.js

HideWindowUI.pdf is misssing

* compare.js make it look good

* add tests

* Update saucelabs.karma.conf.js

* Fix for #905 #1163 #1317

adler32cs is no longer maintained, made package.json point to my fork of  adler32cs that contains the loader.js fix

* small modification

* Update outline.js

* Add files via upload

* Update standard.spec.js

* Update karma.conf.js to load outline.js

* Update saucelabs.karma.conf.js to load outline.js

* chore(package): update rollup-plugin-babel to version 3.0.3

* chore(package): update karma to version 2.0.0

* Add new method for internal, getTextColor

* Update dist files and docs to include getTextColor

* Revise getTextColor to return hex code; add new spec

* Compiled assets for getTextColor modifications

* Updates spec and documentation per feedback

* chore(package): update uglify-js to version 3.3.5

Closes #1506

* simplify

* addCreationDate

* Update standard.spec.js

* Update standard.spec.js

* Update jspdf.js

* Update standard.spec.js

* Update standard.spec.js

* Add png adam7 interlace (#6)

* Update png.js

Adapted from here 
foliojs/png.js#8

* make it look good

* fix possible merging error

* fix minor bug

* hopefull removed all dupes

* Update main.js

* Don't skip HideWindowUI

* Update addimage.js

* Update compare.js

* Add files via upload

* Update jspdf.js

* Update jspdf.js

* Update addhtml.js

* Update outline.js

* Update cell.js

* Update annotations.js

* Update from_html.js

* Update context2d.js

* Update acroform.js

* Update addimage.js

* Update karma.conf.js

* Create getImageProperties.spec.js

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants