Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save As Overlay: Put cursor to right of current file name #204

Closed
PropGit opened this issue Jul 27, 2015 · 12 comments · Fixed by #285
Closed

Save As Overlay: Put cursor to right of current file name #204

PropGit opened this issue Jul 27, 2015 · 12 comments · Fixed by #285
Milestone

Comments

@PropGit
Copy link
Contributor

PropGit commented Jul 27, 2015

Issue #152, in Sprint 6 indicated that the field should be focused and the cursor should be to the right of the file name.

The cursor still appears to the left of the file name upon activation of the Save As overlay. Please fix it so that the cursor appears to the right of the current file name every time the overlay is activated.

@PropGit
Copy link
Contributor Author

PropGit commented Oct 1, 2015

[Bug Introduced]
The solution employed to solve this issue causes cursor navigation to fail while editing the filename.

Clicking in the field (to place the cursor anywhere but at the end), cursor keys, HOME, Ctrl and/or Shift + cursor key combinations (and more) are thwarted, forcing the user to edit the whole filename only from the right side. Any cursor movement is undone and the cursor is once again returned to the right side of the filename.

@PropGit PropGit reopened this Oct 1, 2015
@phated
Copy link
Contributor

phated commented Oct 1, 2015

@PropGit I am unable to reproduce what you are explaining. None of the code I modified would cause it either

@PropGit
Copy link
Contributor Author

PropGit commented Oct 1, 2015

@phated - Whoa... is this perhaps a Windows thing or a Chrome 45 thing?

Wait. I built off of the break-compat branch; perhaps that's the source of the problem. Maybe it's a non-issue for the pre-release you're building today?

@phated
Copy link
Contributor

phated commented Oct 1, 2015

@PropGit I am using Chrome 45 on my mac. I will try to get a windows VM running but the cursor stuff shouldn't be platform dependent. The break-compat branch had the same changes in it.

@PropGit
Copy link
Contributor Author

PropGit commented Oct 1, 2015

@phated - I'll make a video then.

@PropGit
Copy link
Contributor Author

PropGit commented Oct 1, 2015

@phated - Here's a demo video of the symptoms I'm seeing.

@phated
Copy link
Contributor

phated commented Oct 1, 2015

@PropGit thanks for the video. I did a fresh install and build and am able to see this behavior now. Working on a fix before the release. Thanks for catching this and showing me.

@phated
Copy link
Contributor

phated commented Oct 1, 2015

@PropGit I've pushed a fix to the master branch. Can you please build from master, test and let me know if it is working? If so, I will cut the release

@PropGit
Copy link
Contributor Author

PropGit commented Oct 1, 2015

@phated - Yes. I will do that now...

@PropGit
Copy link
Contributor Author

PropGit commented Oct 1, 2015

@phated - Success! It works perfectly now, thank you!

@PropGit PropGit closed this as completed Oct 1, 2015
@phated
Copy link
Contributor

phated commented Oct 1, 2015

@PropGit Hooray! Cutting the release shortly

@PropGit
Copy link
Contributor Author

PropGit commented Oct 3, 2015

Verified fixed.

@phated phated removed their assignment Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants