RX/TX Bar #147
Merged
RX/TX Bar #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| outputConsole.style.overflow = 'auto'; | ||
| outputConsole.style.whiteSpace = 'pre-wrap'; | ||
| el.appendChild(outputConsole); | ||
| } | ||
| if(!transmission) { | ||
| transmission = document.createElement('div'); | ||
| transmission.id = 'transmission'; |
There was a problem hiding this comment.
you don't need to add an ID
|
updated based on comments above. |
|
updated with timeout changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a status bar for displaying transmission events between the host and serial device. RX will flash blue when data is received from the connected device. TX will flash red when data is sent to the connected device.
Where should the reviewer start?
Pull this branch to see the new status bar below the debug output.
How should this be manually tested?
Connect a BASIC Stamp. Load in some looping code. Download code to the board. Notice the red flashing TX on download. Notice the blue flashing RX as debug information is sent to the host.
Any background context you want to provide?
Using flux with a new transmission store. Actions are dispatched from the device store when rx/tx events are found.
What are the relevant tickets?
References #78
Screenshots (if appropriate)