Create and update example project on launch #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +83,7 @@ function onRender(err){ | |||
| } = app; | |||
|
|
|||
| const { | |||
| ensureExampleProject, | |||
|
@PropGit a warning on this feature... it is adding quite a bit of time to the startup of the application when the examples directory doesn't exist because it is creating all those files before first render (which makes sense). |
phated
added a commit
that referenced
this pull request
Oct 30, 2015
Create and update example project on launch
|
@phated - noted, thanks. We'll perhaps add a prompt message ahead of that scenario on a future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This PR adds an examples folder with source files on launch. This will automatically add new files if they exist in the examples directory but are not in the user's example project, allowing new files to be added later.
How should this be tested by the reviewer?
Launch the app and verify that the Examples project exists and is populated. Add a new example and rebuild, verify that it is added after the fact.
What are the relevant tickets?
Closes #295