Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't view documentation of a subobject with debug when it doesn't contain a clock frequency setting #138

Closed
PropGit opened this issue Mar 12, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@PropGit
Copy link
Contributor

PropGit commented Mar 12, 2021

From @ChipGracey:

We need to change the debug clock frequency sensitivity so that we only care if they are trying to download that file. When I try to make documentation View of my file oh, it gets mad because I don't have a clock frequency set up and I have debug statements, but the parent is always going to supply the clock frequency. So, we need to ignore it, and less the user wants to download.

@PropGit PropGit added the bug Something isn't working label Mar 12, 2021
@PropGit PropGit added this to the Triage milestone Mar 12, 2021
@PropGit PropGit self-assigned this Mar 12, 2021
@PropGit
Copy link
Contributor Author

PropGit commented Mar 12, 2021

@ChipGracey - Do you mean this change will be done in the compiler (through a flag so it knows when...) or do you mean in the Propeller Tool (we should automatically compile without debug) when... we're only compiling for documentation purposes?

I think the later makes the most sense, but am not sure of your intent.

@PropGit PropGit added this to To do in 2021 Release 4 via automation Mar 12, 2021
@PropGit PropGit removed this from the Triage milestone Mar 12, 2021
@ChipGracey
Copy link

ChipGracey commented Mar 12, 2021 via email

@PropGit
Copy link
Contributor Author

PropGit commented Mar 12, 2021

Okay, that's what we'll do then.

@PropGit
Copy link
Contributor Author

PropGit commented Mar 12, 2021

Fixed in v2.5.3.

@PropGit PropGit closed this as completed Mar 12, 2021
2021 Release 4 automation moved this from To do to Done Mar 12, 2021
@PropGit PropGit changed the title Adjust Debug Clock Frequency sensitivity to allow documentation view of subobjects with debug Can't view documentation of a subobject with debug when it doesn't contain a clock frequency setting Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants