-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recv.c #198
Comments
Nice catch. Do you want to try the fix in demo.blockly.parallax.com? |
This is the fix thus far. Perhaps wait on demo until it's tested, as may be some other gremlin to satisfy! |
Okay, thanks. I saw in some other correspondence that sscan might be up to
some mischief too. Will wait for more news before updating.
…On Wed, Jul 3, 2019 at 11:48 AM Michael ***@***.***> wrote:
This is the fix thus far. Perhaps wait on demo until it's tested, as may
be some other gremlin to satisfy!
Will know in a couple days.
recv.c.txt
<https://github.com/parallaxinc/Simple-Libraries/files/3356412/recv.c.txt>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#198?email_source=notifications&email_token=ACYKA5776GMWYGH52D2Z4FLP5TX6XA5CNFSM4H5IQNQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFLSIQ#issuecomment-508213538>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACYKA5446P34OFNJSE7HSDTP5TX6XANCNFSM4H5IQNQA>
.
|
v1.4.139 Test correction to issue #198
On second thought, I'll update the Dev branch with anything that needs testing. You can get the zip with everything else current here: |
wifi_recv command can "block forever" if tcp rx buffer empty when bytes requested.
one issue at a glance.... line 70 looks like a problem.
if(bytesReady == 0) return 0;
because in that scenario, line 79 doesn't get called !
wifi_simpletermResume();
so the debug term will appear to crash.
There may be more to this, and the same issue applies to wifi_scan.
I don't think wifi_recv should block under any circumstances. However- the "block forever" concern may just be an issue for Badge users, as simpleterm is required for all comms.
The text was updated successfully, but these errors were encountered: