Refactoring Phase 2 #100
Merged
Refactoring Phase 2 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
force-pushed
the
refactoring_phase_2
branch
from
3df50f2
to
99e5f3c
Compare
ionut-arm
reviewed
Jul 21, 2020
| @@ -0,0 +1,91 @@ | |||
| use crate::constants::response_code::Tss2ResponseCode; | |||
There was a problem hiding this comment.
I like the split, it makes sense.
Superhepper
force-pushed
the
refactoring_phase_2
branch
4 times, most recently
from
f1c4555
to
819a8eb
Compare
hug-dev
reviewed
Jul 23, 2020
- Moved tickets into structres dir. - Created new dir constants - Renamed constants.rs into tss.rs and moved into constants dir. - Moved algorithm/specifiers.rs into constants dir and renamed it to algorithm.rs. - Created tags as subdir to constants. - Renamed utils/tags.rs to structure.rs and moved it into the constants/tags dir. - Moved error part of respopnse_code.rs into sepparate file error.rs and moved response_code.rs into constants dir. - Changed lints in lib.rs to make more sense. - Moved lint from lib.rsd to constants/mod.rs Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
Superhepper
force-pushed
the
refactoring_phase_2
branch
from
819a8eb
to
d7f55b3
Compare
Done |
ionut-arm
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #87
it to algorithm.rs.
constants/tags dir.
and moved response_code.rs into constants dir.
Signed-off-by: Jesper Brynolf jesper.brynolf@gmail.com