-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Phase 2 #100
Refactoring Phase 2 #100
Conversation
3df50f2
to
99e5f3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me!
@@ -0,0 +1,91 @@ | |||
use crate::constants::response_code::Tss2ResponseCode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the split, it makes sense.
f1c4555
to
819a8eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks good to me, thanks a lot for working on this! It will be primordial for more stable releases.
I have only one request: could you please check all new files if they all have the copyright notice on top and add them if not?
- Moved tickets into structres dir. - Created new dir constants - Renamed constants.rs into tss.rs and moved into constants dir. - Moved algorithm/specifiers.rs into constants dir and renamed it to algorithm.rs. - Created tags as subdir to constants. - Renamed utils/tags.rs to structure.rs and moved it into the constants/tags dir. - Moved error part of respopnse_code.rs into sepparate file error.rs and moved response_code.rs into constants dir. - Changed lints in lib.rs to make more sense. - Moved lint from lib.rsd to constants/mod.rs Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
819a8eb
to
d7f55b3
Compare
Done |
This relates to #87
it to algorithm.rs.
constants/tags dir.
and moved response_code.rs into constants dir.
Signed-off-by: Jesper Brynolf jesper.brynolf@gmail.com