-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation to Context methods. #168
Conversation
ef8850a
to
69e1d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, are you intending to add references to the spec?
I am not sure. I might. But most of all I am going to add some examples before this is done. |
6cb4e59
to
b1fa8a4
Compare
24a27aa
to
e763a55
Compare
Do you think the links to the specifications are a good thing? |
I don't think that that makes a lot of sense. The |
I think that we could do with a higher level crates that are more of the |
e84958f
to
c7f23e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with it either way, whether the references to the spec are there or not, I'm just glad we have code examples now
Oh, absolutely! Thanks @Superhepper for the code examples and documentation! |
I think this PR is finished now. Even though the documentation of Context is not finished it contains a couple a good examples so it is easy for others to continue. And I do not want the PR to be to big. |
- Added documentation to the Context methods so that they at least have some small documentation. Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
c7f23e8
to
a03814c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
Improve TPM provider
they at least have some small documentation.
Signed-off-by: Jesper Brynolf jesper.brynolf@gmail.com