Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare patch release to fix docs.rs build #213

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Mar 25, 2021

No description provided.

Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
@ionut-arm
Copy link
Member

The changes worked for cross-compilation at least, hopefully docs.rs is sorted too.

@hug-dev hug-dev merged commit 56454e2 into parallaxsecond:main Mar 25, 2021
@hug-dev hug-dev deleted the doc-fix-release branch March 25, 2021 10:32
@hug-dev
Copy link
Member Author

hug-dev commented Mar 25, 2021

It worked 🥳
https://docs.rs/tss-esapi-sys/0.1.1/tss_esapi_sys/

@ionut-arm
Copy link
Member

Actually - I'm a bit worried/curious. That's the binding for x86-unknown-linux-gnu but there's clearly a difference between that and what a user running on Aarch64 Linux would see. Isn't that common for FFI crates in docs.rs? I don't remember if there was anything about it in that blogpost about doing FFI in Rust.

@hug-dev
Copy link
Member Author

hug-dev commented Mar 25, 2021

On docs.rs you can use the "Platform" option at the top to change what platform the docs have been generated for. We can customize that for the targets we want. It's very easy

@ionut-arm
Copy link
Member

Oh wow, that's quite nice! Maybe we should do that for our crates

tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants