Link to tss2-sys as well #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tss2-sys to the list of libraries we explicitly link to. The reason is that Parsec was having issues linking correctly for cross-compilation, and explicitly linking helped. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Superhepper
approved these changes
Apr 30, 2021
ionut-arm
added a commit
to ionut-arm/rust-tss-esapi
that referenced
this pull request
May 6, 2021
The tss2-sys is only being linked to explicitly when the bindings are not generated, after parallaxsecond#226. This fixes that discrepancy. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
that referenced
this pull request
Jun 17, 2021
The tss2-sys is only being linked to explicitly when the bindings are not generated, after #226. This fixes that discrepancy. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds tss2-sys to the list of libraries we explicitly link
to. The reason is that Parsec was having issues linking correctly for
cross-compilation, and explicitly linking helped.